Page MenuHomePhabricator
Feed All Stories

Jan 15 2025

roqqit closed D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 22:25
roqqit closed D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 22:24
roqqit committed rABCc801d8fc621a: [test] Cleanup unnecessary sync_all in rpc_net.py (authored by roqqit).
[test] Cleanup unnecessary sync_all in rpc_net.py
Jan 15 2025, 22:24
roqqit closed D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 22:24
roqqit committed rABC7878d95a0db2: [test] clarify rpc_net & p2p_disconnect_ban functional tests (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[test] clarify rpc_net & p2p_disconnect_ban functional tests
Jan 15 2025, 22:24
Fabien accepted D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
Jan 15 2025, 22:12
Fabien added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

This is a rare case where I don't think it's worth doing 2 steps. It's easy enough to get the cumulative value (you can use D17449 if you want to) that it doesn't desserve a half step

Jan 15 2025, 22:10
Fabien requested changes to D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 15 2025, 22:03
Fabien accepted D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 15 2025, 22:03
Fabien accepted D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 22:02
Fabien accepted D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 21:57
Fabien accepted D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 21:55
Fabien accepted D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 21:49
Fabien requested changes to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 21:45
tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 21:38
Fabien accepted D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Jan 15 2025, 21:34
Fabien accepted D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.
Jan 15 2025, 21:32
bytesofman closed D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 21:29
bytesofman committed rABCe348c74a4fdd: [ecash-lib] Add toHex method to Script class (authored by bytesofman).
[ecash-lib] Add toHex method to Script class
Jan 15 2025, 21:29
Fabien accepted D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 21:24
Fabien accepted D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 21:24
teamcity updated the summary of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
Jan 15 2025, 20:55
PiRK requested review of D17541: Cache block index entry corresponding to assumeutxo snapshot base blockhash.
Jan 15 2025, 20:55
PiRK updated the diff for D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

rebase

Jan 15 2025, 20:42
PiRK updated the diff for D17536: Documentation improvements for assumeutxo.

rebase

Jan 15 2025, 20:30
PiRK updated the diff for D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

rebase

Jan 15 2025, 20:29
PiRK updated the diff for D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

rebase

Jan 15 2025, 19:56
PiRK updated the diff for D17533: Move block-storage-related logic to ChainstateManager.

remove wrong negative lock annotation

Jan 15 2025, 19:54
PiRK accepted D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 19:47
PiRK accepted D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 19:46
bytesofman published D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip for review.
Jan 15 2025, 19:31
teamcity updated the summary of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 18:23
roqqit requested review of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 18:23
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.

Fix wait_until_helper -> self.wait_until

Jan 15 2025, 17:29
roqqit added inline comments to D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 17:26
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 17:20
roqqit requested review of D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 15 2025, 17:19
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toScriptHex method to Script class to [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 13:38
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toHex it is

Jan 15 2025, 13:37
teamcity added a comment to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:21
teamcity added a comment to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:20
teamcity added a comment to D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 11:15
teamcity added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:12
teamcity added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:11
PiRK planned changes to D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.

needs a rebase

Jan 15 2025, 11:11
PiRK planned changes to D17536: Documentation improvements for assumeutxo.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 11:10
PiRK added a comment to D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.

needs a rebase

Jan 15 2025, 11:10
PiRK planned changes to D17533: Move block-storage-related logic to ChainstateManager.

lock issue detected by clang

Jan 15 2025, 11:10
teamcity added a comment to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 11:08
teamcity added a comment to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 11:06
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:05
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:04
teamcity added a comment to D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 11:01
teamcity updated the summary of D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:00
PiRK requested review of D17537: Move CheckBlockIndex() from Chainstate to ChainstateManager.
Jan 15 2025, 11:00
hazzarust closed D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 15 2025, 11:00
hazzarust committed rABCf7d1497b7029: [Chronik] Add chronik_info method into lib.rs (authored by hazzarust).
[Chronik] Add chronik_info method into lib.rs
Jan 15 2025, 11:00
teamcity updated the summary of D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 10:57
PiRK requested review of D17536: Documentation improvements for assumeutxo.
Jan 15 2025, 10:57
PiRK added inline comments to D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:56
PiRK requested review of D17535: Fix initialization of setBlockIndexCandidates when working with multiple chainstates.
Jan 15 2025, 10:54
teamcity updated the summary of D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:53
PiRK requested review of D17534: Tighten requirements for adding elements to setBlockIndexCandidates.
Jan 15 2025, 10:53
teamcity updated the summary of D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 10:51
PiRK requested review of D17533: Move block-storage-related logic to ChainstateManager.
Jan 15 2025, 10:51
teamcity updated the summary of D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Jan 15 2025, 10:50
PiRK requested review of D17532: Add wrapper for adding entries to a chainstate's block index candidates.
Jan 15 2025, 10:50
PiRK updated the diff for D17440: Update CheckBlockIndex invariants for chains based on an assumeutxo snapshot.

rebase, remove now useless hack to skip checkblockindex from D14653

Jan 15 2025, 10:48
PiRK accepted D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 09:21
Fabien accepted D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 09:20
PiRK requested changes to D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 09:18
Fabien accepted D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 09:18
PiRK accepted D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 09:16
Fabien requested changes to D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.

Not really related to the changes but since you are touching the code it's best to fix it

Jan 15 2025, 09:15
Fabien requested changes to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 08:59
Fabien added a comment to D17527: [ecash-lib] Add toHex method to Script class.

I don't want to start bike shedding but this is the worst possible name. You can convert an address to script hex, that makes sense. But a script to script hex makes zero sense.
I also don't see how you can be confused with the toHex() function which is not a script method. That's what namespace is about.

Jan 15 2025, 08:59
teamcity added a comment to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 00:45
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

update test name

Jan 15 2025, 00:41
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toString method to Script class to [ecash-lib] Add toScriptHex method to Script class.
Jan 15 2025, 00:40
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toString becomes toScriptHex

Jan 15 2025, 00:39
bytesofman added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 15 2025, 00:39
roqqit updated the summary of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:31
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.

Add back accidentally deleted comment

Jan 15 2025, 00:13
teamcity updated the summary of D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 00:11
roqqit requested review of D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 00:11
teamcity updated the summary of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:07
roqqit requested review of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:07
teamcity updated the summary of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 00:01
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 00:01

Jan 14 2025

Fabien accepted D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 22:03
hazzarust retitled D17528: [Chronik] Add chronik_info method into lib.rs from [Chronik] Added chronik_info method into lib.rs to retrieve ChronikInfo struct and thus the version to [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 21:37
hazzarust updated the diff for D17528: [Chronik] Add chronik_info method into lib.rs.

Added the regex test for version returned from ChronikInfo

Jan 14 2025, 21:26
Fabien requested changes to D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 21:00
hazzarust updated the diff for D17528: [Chronik] Add chronik_info method into lib.rs.

Added assert_eq!() test for chronik version returned

Jan 14 2025, 20:56
Fabien added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:53
Fabien added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:52
Fabien requested changes to D17528: [Chronik] Add chronik_info method into lib.rs.
Jan 14 2025, 20:51
tobias_ruck added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Jan 14 2025, 20:50