Added full activation test

I'll merge the test into D5244 as advised by @jasonbcox

Remove pre-phonon testing of mempool packages. Instead the D5245 test will be improved to test activation.

typo, docstring fix

In D5244#127826, @deadalnix wrote:

What @markblundeberg said.

Remove redundant changes in validation.cpp

Rebase to fix merge conflict with release notes.

There is already a facility to run test pre and post upgrade. Please use this unless you are specifically testing for the activation.

In D5244#127423, @Fabien wrote:

Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.

• Replace fork with ponon-upgrade in parameter description.
• Move maxorphantx to common_params
• Add a comment on why minimumAmount was added
• Add release notes

Rebase, rename test, some test cleanup

Ensure test selects inputs with enough coins during the second run

typo

test braino, add to cmake

Header inclusion order, explicit SetMTP, rename test

Marking as planned changes due to issues with parent diff

Replaced whitespace with tab in CMakeList.txt (sorry for the noise)

Added mempool.cpp to CMakeList.txt

New approach. Instead of modifing the existing nulldummy test, create a new test following deadalnix's test plan above.

According to telegram discussion, this change is controversial and needs to be split into 7 diffs.

Rename class LastBlock -> BlockHeader
Rename method tip -> hash_as_int

In D2508#58110, @deadalnix wrote:

This diff suffer from the classic syndrome of doing several things at once, causing discussion about one of these things to delay progress and all the others and everybody getting frustrated.

removed unneeded block generation, replace bytes_to_hex_str with ToHex, re-added block version

ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.

What's the plan for this test after NULLDUMMY consensus activation, I'm curious? Obviously it won't accept that last block anymore ...

lastblockhash -> lastblock.hash

This conflicts with D2341

What changes do you want @jasonbcox?

Turns out the failure in D2431 was unrelated to this. I'm happy to close this unlanded.

Add missing newline

This fixes test failure for me in D2431. The symptom locally was that bitcoind was unable to get a lock on a file in my ~/.bitcoin folder.

Fix abc-replay-protection + nits

Fix name error in parameter to bitcoind

Update after prerequisite todo items have landed. Cleanup and rebase.

MTP in test

Check that MTP is used, not nTime

Some nits addressed

Nit addressed

Port over missing comment

LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.

LGTM. A couple of nits. You forgot attribution.