Address comment.

I can split this diff in two, if needed. I'm not sure this test should be created.

rebase

Update tests to match the merged spec (test vectors: V6, V7, I10, I4, I5, I2, I1).

They don't have a fix. It seems they've never bumped into this problem. Core v18.0 is the only bug-free branch only because they removed the rpc entirely. I suppose we're only planning to remove that rpc in v20.0.

Yeah, the issue exists in core in all actively maintained branches, except for v18.0 (removed the rpc) which should be released soon. Thanks for handling this, Fabien!

Remove extra space.

Remove extra space.

Revert the mod n change.

Add mocktime to avoid time dependencies.

Added functional test

Improved readability of the functional test.

Refactored the ban testing code to only use public interfaces.

Addressed comments.

Moved mempool reorg handling to other diff, refactored the functional test

Fixed pool access outside of crictical section

Separated the functional test and fixed abc-replay-protection

Applied requested changes. Refactored unit test for readability.

Included another test for non replay protected txn crossing the fork boundary

Many small changes as requested.

Solved lint error.

Included test cases in different txn orders

Fixed mempool handling on reorg and added fixed/tested the ban logic

I will resubmit this diff for review after Feb 15th

scriptSig -> signature scripts

signtures->scriptSig

Handled case when disconnectpool is nullptr, added better description

Included code to remove invalid transactions from the mempool on a reorg that deactivates the fork. Updated the test to check the state of the mempool when standardness checks are disabled.

Included checks of the parsed results of IsWitnessProgram