Rebased on master to resolve merge conflicts (some tests were added to TEST_LIST, which is being deleted bz this DIFF)
I've also re-run all tests to get updated timing.json, which now includes the new tests.

I've done some preliminary analysis on call graph generations and I'm shraing the results here.
Unfortunately I did not have enough time to actually analyze bitocin-abc code and find the low hanging fruit, that task description mentions.
Still' I hope, that's a good start.

Fix according to review comments

Minor fix: Renamed Timings.build_dir to dir

Splitting this update in smaller commits. This commit saves test timing in build_dir/timing.json

I'll try to work on this...

Is it OK to store timing.json in git (test/function/timing.json)?

In D1089#20170, @schancel wrote:

and it looks like you may need to run autopep8 on the file.

autopep8 was already run before the first commit. It looks like arc diff also runs arc lint. Unitl I've installed autopep8 or arc diff kept failing.

Rebased onto master

Addressed review

Hmm, PushSig already has default SigHashType parameter (introduced in D932):

Rebasing onto master to avoid conflicts

Rebasing again after doing git fetch origin master

Rebasing on master (arc land failed)

Addressed review comments

Here are some guidelines on how to get out of the mess, created by stacking and rebasing commits.

• Some of your commits might be detached (as a result of wrong rebase). To find them use git log --graph --decorate --pretty=oneline $(git rev-list -g --all --author=yourName)
• Match those commits with Phabricator Diffs by visiting https://reviews.bitcoinabc.org/Dxxxx and checking hashes in Revision Contents/Commits
• One you found detached commit, create a branch from it: git branch yourBranchName commitHash
• Someone else might have already pushed his commits onto master. To avoid problems with landing your commits, fetch remote master changes by doing git fetch origin master && git rebase -i origin/master
• Rebase your branch: on master: git rebase master -i
• Make and necessary changes and commit them
• To check if arc still maintain reference to the Diff, run: arc which
• Arc probably lost the reference to your Diff. It also sometimes mixes up what was already commited and what not. To specify Diff and commit range, use Use arc diff --update Dxxx firstCommitHash

Rebased to fix permissions on files, that I have modified
I also removed executable flag from src/secp256k1/src/modules/recovery/main_impl.h (I have checked old versions and this flag is already present on master)

Part2 - updating Diff, so that it now contais both commits for this task

Updating already accepted revision D1071, becaue it has file mode changes

Trying to fix permission (part 4)

Trying to fix the permission (again)

In D1089#20130, @schancel wrote:

You are my hero. I'll review this ASAP. A quick passover though:

@jasonbcox, should I also try to remove the following functions from DstEncode.h:

@schancel, how is this task different from T164?

In D1073#19870, @deadalnix wrote:

It doesn't looks like this is fixed.

fixed executable flag permission (again :-())

fixed 2 of 3 review comments. The locking question remains open

Fixed permissions (also on files src/rpc/mining.cpp, rpc/rpc/misc.cpp, whose permissions was not modified by original commit)

Fixed file permissions

Here is the first chunk of T170 – I replaced usages of Params() in addrdb.cpp and fixed all refrences.