Page MenuHomePhabricator
People roqqit

roqqit (Roqqit)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2024, 16:34 (40 w, 3 d)

Recent Activity
View All

Fri, Mar 21

roqqit closed D17840: [avalanche] Fix flaky proof rank comparison in processor_tests.
Fri, Mar 21, 14:54
roqqit committed rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests (authored by roqqit).
[avalanche] Fix flaky proof rank comparison in processor_tests
Fri, Mar 21, 14:54

Thu, Mar 20

roqqit requested changes to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Thu, Mar 20, 17:25
roqqit closed D17834: [avalanche] Refactor helpers to build avaproofs messages.
Thu, Mar 20, 17:06
roqqit committed rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages (authored by roqqit).
[avalanche] Refactor helpers to build avaproofs messages
Thu, Mar 20, 17:06
roqqit committed rABC2b95ae7e2f43: [avalanche] Cleanup unused prefilled proof index set (authored by roqqit).
[avalanche] Cleanup unused prefilled proof index set
Thu, Mar 20, 17:04
roqqit closed D17833: [avalanche] Cleanup unused prefilled proof index set.
Thu, Mar 20, 17:04
roqqit requested review of D17840: [avalanche] Fix flaky proof rank comparison in processor_tests.
Thu, Mar 20, 17:04

Wed, Mar 19

roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

back to you

Wed, Mar 19, 22:56
roqqit accepted D17829: [avalanche] Add to the recently finalized items filter at callsite.

This looks a bit odd to move it to the callsite but since it is moving in the right direction with regards to the processor FIXME, it is probably a small step in the right direction.

Wed, Mar 19, 22:53
roqqit requested review of D17834: [avalanche] Refactor helpers to build avaproofs messages.
Wed, Mar 19, 22:48
roqqit requested review of D17833: [avalanche] Cleanup unused prefilled proof index set.
Wed, Mar 19, 21:44

Tue, Mar 18

roqqit committed rABCf7b0bdf7c762: [electrum] Fix typo in trezor firmware warning text (authored by roqqit).
[electrum] Fix typo in trezor firmware warning text
Tue, Mar 18, 16:31
roqqit closed D17818: [electrum] Fix typo in trezor firmware warning text.
Tue, Mar 18, 16:31
roqqit requested review of D17818: [electrum] Fix typo in trezor firmware warning text.
Tue, Mar 18, 15:52
roqqit accepted D17817: [avalanche] Improve performance of inventory filtering.
Tue, Mar 18, 15:46

Mon, Mar 17

roqqit closed D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 22:10
roqqit committed rABCcf38f5e5d94a: [avalanche] Cleanup circular dependency between peer manager and contender cache (authored by roqqit).
[avalanche] Cleanup circular dependency between peer manager and contender cache
Mon, Mar 17, 22:10
roqqit requested review of D17813: [avalanche] Cleanup circular dependency between peer manager and contender cache.
Mon, Mar 17, 19:44

Fri, Mar 14

roqqit closed D17788: [avalanche] Move contender cache to peer manager.
Fri, Mar 14, 20:40
roqqit committed rABC821580a6ab15: [avalanche] Move contender cache to peer manager (authored by roqqit).
[avalanche] Move contender cache to peer manager
Fri, Mar 14, 20:40

Thu, Mar 13

roqqit updated the diff for D17788: [avalanche] Move contender cache to peer manager.
  • add lint exception for circular dependency
  • fix lock annotations
Thu, Mar 13, 18:07
roqqit accepted D17801: [avalanche] Add a mempool isWorthPolling method for txs.
Thu, Mar 13, 17:57
roqqit accepted D17802: [Cashtab] Correct issue of two tests with the same name.
Thu, Mar 13, 17:56

Wed, Mar 12

roqqit planned changes to D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:39
roqqit requested review of D17788: [avalanche] Move contender cache to peer manager.
Wed, Mar 12, 19:26

Tue, Mar 4

roqqit accepted D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Tue, Mar 4, 16:55

Mon, Mar 3

roqqit closed D17728: [avalanche] Down-rank rejected contenders.
Mon, Mar 3, 20:00
roqqit committed rABC601acac03dc6: [avalanche] Down-rank rejected contenders (authored by roqqit).
[avalanche] Down-rank rejected contenders
Mon, Mar 3, 20:00
roqqit closed D17737: [avalanche] Fix a race in contenders voting test (again).
Mon, Mar 3, 19:59
roqqit committed rABC489c9cfea31a: [avalanche] Fix a race in contenders voting test (again) (authored by roqqit).
[avalanche] Fix a race in contenders voting test (again)
Mon, Mar 3, 19:59
roqqit updated the diff for D17728: [avalanche] Down-rank rejected contenders.

feedback

Mon, Mar 3, 17:43
roqqit closed D17700: [avalanche] Process responses to stake contender polls.
Mon, Mar 3, 17:11
roqqit committed rABCd25b7436bca1: [avalanche] Process responses to stake contender polls (authored by roqqit).
[avalanche] Process responses to stake contender polls
Mon, Mar 3, 17:11
roqqit requested review of D17737: [avalanche] Fix a race in contenders voting test (again).
Mon, Mar 3, 16:57

Fri, Feb 28

roqqit closed D17729: [avalanche] Fix a race in contenders voting test.
Fri, Feb 28, 21:45
roqqit committed rABCd029363ecc33: [avalanche] Fix a race in contenders voting test (authored by roqqit).
[avalanche] Fix a race in contenders voting test
Fri, Feb 28, 21:45
roqqit accepted D17730: tests: use noban_tx_relay in more tests.
Fri, Feb 28, 21:22
roqqit requested review of D17729: [avalanche] Fix a race in contenders voting test.
Fri, Feb 28, 21:15
roqqit accepted D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.

reviewer note: the call to CustomInit() got added to BaseIndex::Start() in one commit and removed in the other. it makes comparing each to this patch a bit weird.

Fri, Feb 28, 18:47
roqqit accepted D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Fri, Feb 28, 18:33
roqqit accepted D17717: [avalanche] Also finalize the ancestors of a transaction.

re: the note at the end of the summary: when you write this other diff, be sure to include test coverage that attempt to poll finalized ancestors. there is risk of regression here otherwise.

Fri, Feb 28, 18:29
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Fri, Feb 28, 18:22
roqqit requested review of D17728: [avalanche] Down-rank rejected contenders.
Fri, Feb 28, 18:21
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Fri, Feb 28, 18:18
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.
  • use proofid as int in more places
  • check stake winner order
  • fix comment
Fri, Feb 28, 17:15

Thu, Feb 27

roqqit abandoned D17582: [avalanche] Add an invalidation latch to contender cache.

no longer needed since D17710

Thu, Feb 27, 21:27
roqqit closed D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Thu, Feb 27, 21:25
roqqit committed rABCdc136cfed9c4: [avalanche] Simplify contenders by treating rejection and invalidation the same (authored by roqqit).
[avalanche] Simplify contenders by treating rejection and invalidation the same
Thu, Feb 27, 21:25
roqqit updated the summary of D17700: [avalanche] Process responses to stake contender polls.
Thu, Feb 27, 21:24
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.
  • rebase on D17710
  • fixed some checks in the functional test not checking what we think they're checking (sort() returns nothing)
  • added a version of setStakingRewardWinners that preserves proofids and does not attempt to re-update the cache
Thu, Feb 27, 21:23
roqqit updated the diff for D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.

re-add and fixup test case for invalidation after finalization

Thu, Feb 27, 21:20
roqqit requested review of D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Thu, Feb 27, 18:29
roqqit closed D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Thu, Feb 27, 16:47
roqqit committed rABCb0cae7ddadea: [avalanche] Return proofids in addition to payout scripts in getWinners (authored by roqqit).
[avalanche] Return proofids in addition to payout scripts in getWinners
Thu, Feb 27, 16:47

Wed, Feb 26

roqqit requested review of D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Wed, Feb 26, 22:51
roqqit requested review of D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Wed, Feb 26, 22:34
roqqit accepted D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Wed, Feb 26, 16:43
roqqit accepted D17703: doc: BaseIndex sync behavior with empty datadir.
Wed, Feb 26, 16:40
roqqit accepted D17702: index: Don't commit a best block before indexing it during sync.
Wed, Feb 26, 16:39
teamcity awarded D17700: [avalanche] Process responses to stake contender polls a Haypence token.
Wed, Feb 26, 09:08

Tue, Feb 25

roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

bump -avastalevotethreshold a bit because some rounds get voted while finalizing the first block

Tue, Feb 25, 23:49
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

add test cases for all invalidated and all stalled contenders

Tue, Feb 25, 22:04
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.
Tue, Feb 25, 21:30
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

fixing locking issues

Tue, Feb 25, 21:30
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.

Early feedback indicates some stuff is missing:

  1. Comment on the outcomes of a stale vote.
  2. Test case if all contenders are rejected.
  3. Test case if all contenders are stalled.
Tue, Feb 25, 20:30
roqqit closed D17699: [avalanche] Clarify and simplify checking polled contenders.
Tue, Feb 25, 20:23
roqqit committed rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders (authored by roqqit).
[avalanche] Clarify and simplify checking polled contenders
Tue, Feb 25, 20:23
roqqit requested review of D17700: [avalanche] Process responses to stake contender polls.
Tue, Feb 25, 20:20
roqqit requested review of D17699: [avalanche] Clarify and simplify checking polled contenders.
Tue, Feb 25, 20:09
roqqit accepted D17698: Avoid inflight polls in getavaaddr_interval_test.
Tue, Feb 25, 16:31
roqqit closed D17696: [avalanche] Make contender test more comprehensive.
Tue, Feb 25, 16:29
roqqit committed rABCdc86c1e90e2a: [avalanche] Make contender test more comprehensive (authored by roqqit).
[avalanche] Make contender test more comprehensive
Tue, Feb 25, 16:29
roqqit closed D17695: [avalanche] Make payout scripts unique in contenders test.
Tue, Feb 25, 16:28
roqqit committed rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test (authored by roqqit).
[avalanche] Make payout scripts unique in contenders test
Tue, Feb 25, 16:28
roqqit closed D17693: [avalanche] Cleanup payout address optionality.
Tue, Feb 25, 16:24
roqqit committed rABCba6cbc602b92: [avalanche] Cleanup payout address optionality (authored by roqqit).
[avalanche] Cleanup payout address optionality
Tue, Feb 25, 16:24
roqqit closed D17694: test: Ignore UTF-8 errors in assert_debug_log.
Tue, Feb 25, 16:22
roqqit committed rABC052eab4970d3: test: Ignore UTF-8 errors in assert_debug_log (authored by fanquake <fanquake@gmail.com>).
test: Ignore UTF-8 errors in assert_debug_log
Tue, Feb 25, 16:22
roqqit updated the diff for D17696: [avalanche] Make contender test more comprehensive.

rebase

Tue, Feb 25, 04:23
roqqit updated the diff for D17695: [avalanche] Make payout scripts unique in contenders test.

skip if wallet isn't available

Tue, Feb 25, 04:21
roqqit requested review of D17696: [avalanche] Make contender test more comprehensive.
Tue, Feb 25, 04:16
roqqit requested review of D17695: [avalanche] Make payout scripts unique in contenders test.
Tue, Feb 25, 04:06
roqqit requested review of D17694: test: Ignore UTF-8 errors in assert_debug_log.
Tue, Feb 25, 00:02

Mon, Feb 24

roqqit requested review of D17693: [avalanche] Cleanup payout address optionality.
Mon, Feb 24, 22:00
roqqit closed D17692: [avalanche] Fix missing wait_until in contender test.
Mon, Feb 24, 19:39
roqqit committed rABC103c143b2bea: [avalanche] Fix missing wait_until in contender test (authored by roqqit).
[avalanche] Fix missing wait_until in contender test
Mon, Feb 24, 19:39
roqqit requested review of D17692: [avalanche] Fix missing wait_until in contender test.
Mon, Feb 24, 18:00
roqqit accepted D17691: test: refactor: use `create_block` parameters.
Mon, Feb 24, 17:37
roqqit accepted D17690: test: remove unnecessary block rehashing prior to solving.
Mon, Feb 24, 16:42

Sun, Feb 23

roqqit accepted D17688: doc: Improve ZMQ documentation.
Sun, Feb 23, 17:03

Fri, Feb 21

roqqit committed rABC0ab1dbf3adcc: [avalanche] Poll for stake contenders (authored by roqqit).
[avalanche] Poll for stake contenders
Fri, Feb 21, 22:07
roqqit closed D17607: [avalanche] Poll for stake contenders.
Fri, Feb 21, 22:07

Feb 19 2025

roqqit updated the diff for D17607: [avalanche] Poll for stake contenders.

Rebase on D17660 to address the feedback about splitting up setContenderStatusForLocalWinners(). It should be more clear now that addToReconcile() is only called once per block.

Feb 19 2025, 22:04
roqqit accepted D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Feb 19 2025, 20:59

Feb 14 2025

roqqit closed D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Feb 14 2025, 17:52
roqqit committed rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners (authored by roqqit).
[avalanche] Improve API for setContenderStatusForLocalWinners
Feb 14 2025, 17:52

Feb 13 2025

roqqit updated the diff for D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.

Avoid unused pollableContenders at call sites for now

Feb 13 2025, 16:59
roqqit added inline comments to D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Feb 13 2025, 16:53

Feb 12 2025

roqqit accepted D17661: Better port collision management for the functional tests.
Feb 12 2025, 23:01