Page MenuHomePhabricator

roqqit (Roqqit)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 12 2024, 16:34 (36 w, 20 h)

Recent Activity

Yesterday

roqqit updated the diff for D17607: [avalanche] Poll for stake contenders.

Rebase on D17660 to address the feedback about splitting up setContenderStatusForLocalWinners(). It should be more clear now that addToReconcile() is only called once per block.

Wed, Feb 19, 22:04
roqqit accepted D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Wed, Feb 19, 20:59

Fri, Feb 14

roqqit closed D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Fri, Feb 14, 17:52
roqqit committed rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners (authored by roqqit).
[avalanche] Improve API for setContenderStatusForLocalWinners
Fri, Feb 14, 17:52

Thu, Feb 13

roqqit updated the diff for D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.

Avoid unused pollableContenders at call sites for now

Thu, Feb 13, 16:59
roqqit added inline comments to D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Thu, Feb 13, 16:53

Wed, Feb 12

roqqit accepted D17661: Better port collision management for the functional tests.
Wed, Feb 12, 23:01
roqqit requested review of D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Wed, Feb 12, 19:03
roqqit accepted D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Wed, Feb 12, 17:27

Tue, Feb 11

roqqit accepted D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Tue, Feb 11, 21:56
roqqit requested changes to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Is there a reason -simplifygbt is a command line arg and not a parameter to getblocktemplate?

Tue, Feb 11, 16:32

Mon, Feb 10

roqqit closed D17615: [avalanche] Add stake contender to AnyVoteItem.
Mon, Feb 10, 17:09
roqqit committed rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem (authored by roqqit).
[avalanche] Add stake contender to AnyVoteItem
Mon, Feb 10, 17:09

Fri, Feb 7

roqqit accepted D17645: wallet: make chain optional for CWallet::Create.
Fri, Feb 7, 19:09
roqqit accepted D17644: CWallet::Create move chain init message up into calling code.
Fri, Feb 7, 18:48
roqqit accepted D17643: refactor: Add CWallet:::AttachChain method.
Fri, Feb 7, 18:47
roqqit accepted D17642: refactor: move first run detection to client code.

nvm. compared the wrong lines side-by-side

Fri, Feb 7, 16:44
roqqit requested changes to D17642: refactor: move first run detection to client code.
Fri, Feb 7, 00:59

Wed, Feb 5

roqqit accepted D17634: chainparams: add blockhash to AssumeutxoData.
Wed, Feb 5, 19:03
roqqit accepted D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Wed, Feb 5, 18:18
roqqit accepted D17632: net_processing: Request assumeutxo background chain blocks.
Wed, Feb 5, 18:06
roqqit accepted D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Wed, Feb 5, 16:45

Mon, Feb 3

roqqit accepted D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Mon, Feb 3, 17:02

Fri, Jan 31

roqqit updated the diff for D17615: [avalanche] Add stake contender to AnyVoteItem.

Make local acceptance match what this node would eventually vote

Fri, Jan 31, 22:07

Thu, Jan 30

roqqit closed D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Thu, Jan 30, 19:38
roqqit committed rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when… (authored by roqqit).
[avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when…
Thu, Jan 30, 19:38
roqqit requested review of D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Thu, Jan 30, 17:11
roqqit published D17607: [avalanche] Poll for stake contenders for review.
Thu, Jan 30, 17:04
roqqit requested review of D17615: [avalanche] Add stake contender to AnyVoteItem.
Thu, Jan 30, 16:59

Wed, Jan 29

roqqit closed D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Wed, Jan 29, 20:38
roqqit committed rABC1d9e9cd37db2: [avalanche] Check that avalanche invalidated items no longer poll in the… (authored by roqqit).
[avalanche] Check that avalanche invalidated items no longer poll in the…
Wed, Jan 29, 20:38
roqqit updated the diff for D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.

Add comments to make it more clear that the test is checking the item is not being polled for

Wed, Jan 29, 17:26
roqqit committed rABCfe50cfef5517: [doc] Cleanup trailing whitespaces (authored by roqqit).
[doc] Cleanup trailing whitespaces
Wed, Jan 29, 17:18
roqqit closed D17602: [doc] Cleanup trailing whitespaces.
Wed, Jan 29, 17:18

Mon, Jan 27

roqqit updated the diff for D17602: [doc] Cleanup trailing whitespaces.

Remove erroneous image file change

Mon, Jan 27, 22:11
roqqit requested review of D17602: [doc] Cleanup trailing whitespaces.
Mon, Jan 27, 22:09
roqqit closed D17589: [avalanche] Clear updates on each call to registerVotes.
Mon, Jan 27, 21:50
roqqit committed rABC221da91fe481: [avalanche] Clear updates on each call to registerVotes (authored by roqqit).
[avalanche] Clear updates on each call to registerVotes
Mon, Jan 27, 21:50
roqqit updated the diff for D17589: [avalanche] Clear updates on each call to registerVotes.

feedback

Mon, Jan 27, 19:41

Fri, Jan 24

roqqit accepted D17585: Bump the timeout for the feature_cltv test.
Fri, Jan 24, 20:09
roqqit accepted D17586: Bump the timeout in p2p_ibd_stalling.
Fri, Jan 24, 20:09
roqqit requested review of D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Fri, Jan 24, 20:07
roqqit requested review of D17589: [avalanche] Clear updates on each call to registerVotes.
Fri, Jan 24, 19:53

Thu, Jan 23

roqqit accepted D17581: [electrum] bump version to 5.4.0 and add release notes.
Thu, Jan 23, 17:54
roqqit requested review of D17582: [avalanche] Add an invalidation latch to contender cache.
Thu, Jan 23, 17:51
roqqit closed D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Thu, Jan 23, 17:46
roqqit committed rABC8a22e311702c: [avalanche] Fixup incorrect comment about contender cache vote status (authored by roqqit).
[avalanche] Fixup incorrect comment about contender cache vote status
Thu, Jan 23, 17:46

Tue, Jan 21

roqqit requested review of D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Tue, Jan 21, 19:36

Jan 16 2025

roqqit closed D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 16 2025, 21:07
roqqit committed rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime (authored by roqqit).
[test] Make test_getpeerinfo more robust by using mocktime
Jan 16 2025, 21:07
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.

Remove errant newline

Jan 16 2025, 18:02
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.

Use assert_equal

Jan 16 2025, 18:00

Jan 15 2025

roqqit closed D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 22:25
roqqit committed rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
[test] Fix intermittent timeouts in various functional tests
Jan 15 2025, 22:25
roqqit committed rABC4b8c65801635: test: Fail if connect_nodes fails (authored by laanwj <126646+laanwj@users.noreply.github.com>).
test: Fail if connect_nodes fails
Jan 15 2025, 22:25
roqqit closed D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 22:25
roqqit closed D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 22:24
roqqit committed rABCc801d8fc621a: [test] Cleanup unnecessary sync_all in rpc_net.py (authored by roqqit).
[test] Cleanup unnecessary sync_all in rpc_net.py
Jan 15 2025, 22:24
roqqit closed D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 22:24
roqqit committed rABC7878d95a0db2: [test] clarify rpc_net & p2p_disconnect_ban functional tests (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[test] clarify rpc_net & p2p_disconnect_ban functional tests
Jan 15 2025, 22:24
roqqit requested review of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 18:23
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.

Fix wait_until_helper -> self.wait_until

Jan 15 2025, 17:29
roqqit added inline comments to D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 17:26
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 17:20
roqqit requested review of D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 15 2025, 17:19
roqqit updated the summary of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:31
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.

Add back accidentally deleted comment

Jan 15 2025, 00:13
roqqit requested review of D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 00:11
roqqit requested review of D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 00:07
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 00:01

Jan 13 2025

roqqit closed D17525: [avalanche] Set vote status for highest ranking contender.
Jan 13 2025, 21:56
roqqit committed rABC1c0e73e93ef7: [avalanche] Set vote status for highest ranking contender (authored by roqqit).
[avalanche] Set vote status for highest ranking contender
Jan 13 2025, 21:56
roqqit closed D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Jan 13 2025, 21:55
roqqit committed rABCbadfc35a942d: [avalanche] Simplify lock into one-liner in processor_tests (authored by roqqit).
[avalanche] Simplify lock into one-liner in processor_tests
Jan 13 2025, 21:55
roqqit requested review of D17525: [avalanche] Set vote status for highest ranking contender.
Jan 13 2025, 19:59
roqqit requested review of D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Jan 13 2025, 19:49

Jan 10 2025

roqqit closed D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 16:46
roqqit committed rABCe9b4cbef3b43: [avalanche] Set all local stake winners as accepted contenders (authored by roqqit).
[avalanche] Set all local stake winners as accepted contenders
Jan 10 2025, 16:46
roqqit updated the diff for D17503: [avalanche] Set all local stake winners as accepted contenders.

Bump mocktime beyond the max registration time so there is not a bunch of flaky winners in the functional test

Jan 10 2025, 00:36
roqqit planned changes to D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:15
roqqit requested review of D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:02

Jan 9 2025

roqqit closed D17498: [avalanche] Re-sort pollable contenders by reward rank.
Jan 9 2025, 21:30
roqqit committed rABC073bfa519c06: [avalanche] Re-sort pollable contenders by reward rank (authored by roqqit).
[avalanche] Re-sort pollable contenders by reward rank
Jan 9 2025, 21:30
roqqit updated the diff for D17498: [avalanche] Re-sort pollable contenders by reward rank.

Reuse numPollable

Jan 9 2025, 16:49

Jan 8 2025

roqqit requested review of D17498: [avalanche] Re-sort pollable contenders by reward rank.
Jan 8 2025, 22:39
roqqit accepted D17497: [avalanche] Fix UB in the reward rank comparator.
Jan 8 2025, 21:45
roqqit closed D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 20:37
roqqit committed rABC11d2e76dd3c3: [avalanche] Refactor reward ranking logic into its own comparator (authored by roqqit).
[avalanche] Refactor reward ranking logic into its own comparator
Jan 8 2025, 20:37
roqqit updated the diff for D17495: [avalanche] Refactor reward ranking logic into its own comparator.

Fix circular dependency

Jan 8 2025, 18:25
roqqit requested review of D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Jan 8 2025, 17:44
roqqit closed D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 8 2025, 16:53
roqqit committed rABC53d16b29628d: [avalanche] Add a way to get pollable contenders from contender cache (authored by roqqit).
[avalanche] Add a way to get pollable contenders from contender cache
Jan 8 2025, 16:53

Jan 7 2025

roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.

Cleanup unnecessary nesting when sorting contenders and make the sorting work the same as staking rewards selection.

Jan 7 2025, 22:22
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.
  • Fix rare sorting case where two proofs have the same rank.
  • Make num pollable a parameter so the processor will have control over how many contenders to poll for.
  • Return number of contenders instead of bool.
  • Fix test not actually checking the contender order.
Jan 7 2025, 20:04

Jan 6 2025

roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.

Move static_assert to processor.h in order to avoid circular dependency

Jan 6 2025, 23:36
roqqit requested review of D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Jan 6 2025, 22:57
roqqit closed D17475: [avalanche] Make ComputeProofRewardRank const.
Jan 6 2025, 21:49
roqqit committed rABC576d79f82e1a: [avalanche] Make ComputeProofRewardRank const (authored by roqqit).
[avalanche] Make ComputeProofRewardRank const
Jan 6 2025, 21:49
roqqit requested review of D17475: [avalanche] Make ComputeProofRewardRank const.
Jan 6 2025, 18:54

Dec 21 2024

roqqit accepted D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Dec 21 2024, 02:33