roqqit (Roqqit)
User

Projects

User does not belong to any projects.

User Details

User Since: Jun 12 2024, 16:34 (26 w, 6 d)

Recent Activity
View All

Yesterday

roqqit requested review of D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.

Tue, Dec 17, 22:35

roqqit closed D17349: [seeder] Bump thread stacksize.

Tue, Dec 17, 21:02

roqqit committed rABC61b79c87cb21: [seeder] Bump thread stacksize (authored by roqqit).

[seeder] Bump thread stacksize

Tue, Dec 17, 21:02

roqqit retitled D17349: [seeder] Bump thread stacksize from [seeder] Respect resource limit for stacksize as set by the system to [seeder] Bump thread stacksize.

Tue, Dec 17, 20:38

roqqit updated the diff for D17349: [seeder] Bump thread stacksize.

Just bump the value because predicting it is proving to be difficult and time consuming

Tue, Dec 17, 20:37

Mon, Dec 16

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.

Mon, Dec 16, 18:20

roqqit updated the diff for D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

Use a debug RPC. Waiting for getavalanchepeerinfo is not sufficient here because its possible for this value to be updated before the contender is added to the cache.

Mon, Dec 16, 17:49

Fri, Dec 13

roqqit closed D17348: [seeder] Return an error when thread creation fails.

Fri, Dec 13, 21:06

roqqit committed rABC200513e58adb: [seeder] Return an error when thread creation fails (authored by roqqit).

[seeder] Return an error when thread creation fails

Fri, Dec 13, 21:06

roqqit closed D17350: [seeder] Reword outdated note in readme.

Fri, Dec 13, 21:05

roqqit committed rABC82d1ab6e576c: [seeder] Reword outdated note in readme (authored by roqqit).

[seeder] Reword outdated note in readme

Fri, Dec 13, 21:05

roqqit requested review of D17350: [seeder] Reword outdated note in readme.

Fri, Dec 13, 20:43

roqqit requested review of D17348: [seeder] Return an error when thread creation fails.

Fri, Dec 13, 20:27

roqqit requested review of D17349: [seeder] Bump thread stacksize.

Fri, Dec 13, 20:27

roqqit updated the test plan for D17349: [seeder] Bump thread stacksize.

Fri, Dec 13, 20:26

roqqit planned changes to D17348: [seeder] Return an error when thread creation fails.

Fri, Dec 13, 20:08

roqqit planned changes to D17349: [seeder] Bump thread stacksize.

Fri, Dec 13, 20:08

roqqit requested review of D17349: [seeder] Bump thread stacksize.

Fri, Dec 13, 20:08

roqqit requested review of D17348: [seeder] Return an error when thread creation fails.

Fri, Dec 13, 19:37

Thu, Dec 12

roqqit requested review of D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

Thu, Dec 12, 22:08

roqqit accepted D17343: [CI] Fix a type in the build configuration file.

Thu, Dec 12, 20:36

roqqit accepted D17341: [CI] Don't run the electrum tests in parallel of the functional tests.

Thu, Dec 12, 20:18

roqqit closed D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.

Thu, Dec 12, 17:34

roqqit committed rABC44da17657e7c: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup (authored by roqqit).

[avalanche] Restrict scope of cs_stakingRewards lock during cleanup

Thu, Dec 12, 17:34

Wed, Dec 11

roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.

Wed, Dec 11, 23:43

roqqit requested review of D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.

Wed, Dec 11, 17:48

Tue, Dec 10

roqqit closed D17331: Add symlink to most recent functional test failure directory.

Tue, Dec 10, 19:57

roqqit committed rABCe9d7a6220c01: Add symlink to most recent functional test failure directory (authored by roqqit).

Add symlink to most recent functional test failure directory

Tue, Dec 10, 19:57

roqqit closed D17330: Run more functional tests in parallel by default.

Tue, Dec 10, 18:08

roqqit committed rABC8917a6f8af6c: Run more functional tests in parallel by default (authored by roqqit).

Run more functional tests in parallel by default

Tue, Dec 10, 18:08

roqqit updated the test plan for D17331: Add symlink to most recent functional test failure directory.

Tue, Dec 10, 17:36

roqqit updated the diff for D17331: Add symlink to most recent functional test failure directory.

move lastfailure to top of build_dir
ignore OSError exceptions on windows (didn't use contextlib.suppress because I don't think we should ignore it on Linux)

Tue, Dec 10, 17:36

roqqit planned changes to D17331: Add symlink to most recent functional test failure directory.

Tue, Dec 10, 16:51

roqqit closed D17329: Remove incorrect note in functional tests doc.

Tue, Dec 10, 16:48

roqqit committed rABCaeee696108b5: Remove incorrect note in functional tests doc (authored by roqqit).

Remove incorrect note in functional tests doc

Tue, Dec 10, 16:48

roqqit added a comment to D17330: Run more functional tests in parallel by default.

In D17330#393720, @PiRK wrote:

Benchmark on my machine:

DEFAULT_JOBS =  (multiprocessing.cpu_count() // 3) + 1
ALL                                        | ✓ Passed  | 1603 s (accumulated)
Runtime: 179 s


DEFAULT_JOBS = multiprocessing.cpu_count()
ALL                                        | ✓ Passed  | 2187 s (accumulated)
Runtime: 95 s

DEFAULT_JOBS = 2 * multiprocessing.cpu_count()
ALL                                        | ✖ Failed  | 2583 s (accumulated)
Runtime: 68 s

With one port issue in the 2 * cpu_count attempt.

RuntimeError: Could not find available PortName.P2P port after 5 attempts.

Tue, Dec 10, 16:47

roqqit requested review of D17331: Add symlink to most recent functional test failure directory.

Tue, Dec 10, 00:51

Mon, Dec 9

roqqit requested review of D17330: Run more functional tests in parallel by default.

Mon, Dec 9, 22:47

roqqit requested review of D17329: Remove incorrect note in functional tests doc.

Mon, Dec 9, 21:54

roqqit closed D17327: Use os.cpu_count in test_runner instead of multiprocessing.

Mon, Dec 9, 21:12

roqqit committed rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing (authored by roqqit).

Use os.cpu_count in test_runner instead of multiprocessing

Mon, Dec 9, 21:12

roqqit requested review of D17327: Use os.cpu_count in test_runner instead of multiprocessing.

Mon, Dec 9, 19:43

roqqit closed D17306: [avalanche] Ensure every connected block has staking rewards computed.

Mon, Dec 9, 17:17

roqqit committed rABC7a92d503f674: [avalanche] Ensure every connected block has staking rewards computed (authored by roqqit).

[avalanche] Ensure every connected block has staking rewards computed

Mon, Dec 9, 17:17

Fri, Dec 6

roqqit updated the diff for D17306: [avalanche] Ensure every connected block has staking rewards computed.

feedback

Fri, Dec 6, 21:23

roqqit accepted D17303: build: Bump libevent minimum version up to 2.1.8.

Fri, Dec 6, 18:36

roqqit updated the diff for D17306: [avalanche] Ensure every connected block has staking rewards computed.

fix potential deadlock

Fri, Dec 6, 16:46

roqqit planned changes to D17306: [avalanche] Ensure every connected block has staking rewards computed.

Fri, Dec 6, 16:27

roqqit requested review of D17306: [avalanche] Ensure every connected block has staking rewards computed.

Fri, Dec 6, 15:13

Wed, Dec 4

roqqit closed D17287: Remove executable file mode from some functional tests.

Wed, Dec 4, 18:41

roqqit committed rABC518391383004: Remove executable file mode from some functional tests (authored by roqqit).

Remove executable file mode from some functional tests

Wed, Dec 4, 18:41

Tue, Dec 3

roqqit updated the diff for D17287: Remove executable file mode from some functional tests.

cleanup shebangs to make lint happy

Tue, Dec 3, 18:19

roqqit requested review of D17287: Remove executable file mode from some functional tests.

Tue, Dec 3, 18:16

Mon, Nov 25

roqqit closed D17189: [avalanche] Fix getdata log not showing stake contender inv type name.

Mon, Nov 25, 16:43

roqqit committed rABC44ea0e528faf: [avalanche] Fix getdata log not showing stake contender inv type name (authored by roqqit).

[avalanche] Fix getdata log not showing stake contender inv type name

Mon, Nov 25, 16:43

Fri, Nov 22

roqqit closed D17190: [avalanche] Remove redundant code to ignore stake contender getdata requests.

Fri, Nov 22, 20:39

roqqit committed rABC2c80192da9a5: [avalanche] Remove redundant code to ignore stake contender getdata requests (authored by roqqit).

[avalanche] Remove redundant code to ignore stake contender getdata requests

Fri, Nov 22, 20:39

roqqit requested review of D17190: [avalanche] Remove redundant code to ignore stake contender getdata requests.

Fri, Nov 22, 18:52

roqqit requested review of D17189: [avalanche] Fix getdata log not showing stake contender inv type name.

Fri, Nov 22, 18:30

Thu, Nov 21

roqqit closed D17171: [avalanche] Cleanup redundant check for avalanche processor.

Thu, Nov 21, 16:51

roqqit committed rABC078a6c85e1e9: [avalanche] Cleanup redundant check for avalanche processor (authored by roqqit).

[avalanche] Cleanup redundant check for avalanche processor

Thu, Nov 21, 16:51

• suthem-969 awarded rABC59076f7b8f83: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test a Love token.

Thu, Nov 21, 15:39 · Restricted Project

• suthem-969 awarded D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test a 100 token.

Thu, Nov 21, 15:00

Wed, Nov 20

roqqit requested review of D17171: [avalanche] Cleanup redundant check for avalanche processor.

Wed, Nov 20, 21:54

roqqit closed D17163: [avalanche] Do not modify the chaintip in stake contender test.

Wed, Nov 20, 17:51

roqqit committed rABCd74a3bd8a0e8: [avalanche] Do not modify the chaintip in stake contender test (authored by roqqit).

[avalanche] Do not modify the chaintip in stake contender test

Wed, Nov 20, 17:51

Tue, Nov 19

teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Piece of Eight token.

Tue, Nov 19, 21:24

roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.

@bot build-tsan

Tue, Nov 19, 21:24

roqqit updated the diff for D17163: [avalanche] Do not modify the chaintip in stake contender test.

Better approach

Tue, Nov 19, 21:23

roqqit retitled D17163: [avalanche] Do not modify the chaintip in stake contender test from [avalanche] Add missing lock in stake contenders test to [avalanche] Do not modify the chaintip in stake contender test.

Tue, Nov 19, 21:23

teamcity awarded D17163: [avalanche] Do not modify the chaintip in stake contender test a Haypence token.

Tue, Nov 19, 21:09

roqqit added a comment to D17163: [avalanche] Do not modify the chaintip in stake contender test.

@bot build-tsan

Tue, Nov 19, 21:09

roqqit requested review of D17163: [avalanche] Do not modify the chaintip in stake contender test.

Tue, Nov 19, 21:08

Mon, Nov 18

roqqit closed D17121: [avalanche] Add stake contender polling.

Mon, Nov 18, 21:47

roqqit committed rABC3b44e6192850: [avalanche] Add stake contender polling (authored by roqqit).

[avalanche] Add stake contender polling

Mon, Nov 18, 21:47

roqqit closed D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.

Mon, Nov 18, 21:46

roqqit committed rABC59076f7b8f83: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test (authored by roqqit).

[avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test

Mon, Nov 18, 21:46 · Restricted Project

roqqit closed D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.

Mon, Nov 18, 21:45

roqqit committed rABCea1205ddb23a: [avalanche] Return pending stake contender status when there is no local… (authored by roqqit).

[avalanche] Return pending stake contender status when there is no local…

Mon, Nov 18, 21:45

roqqit updated the diff for D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.

Added back an invalid case. It is incomplete since the local winner does not actually trigger an ACCEPT vote, but this should make it more obvious where that test is heading.

Mon, Nov 18, 18:33

roqqit requested review of D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.

Mon, Nov 18, 18:28

roqqit accepted D17159: util: optimize HexStr.

Mon, Nov 18, 17:42

roqqit accepted D17158: Handle invalid hex encoding in ParseHex.

Mon, Nov 18, 17:22

roqqit accepted D17157: util: Add ParseHex<std::byte>() helper.

Mon, Nov 18, 17:16

roqqit accepted D17156: refactor: Take Span in SetSeed.

Mon, Nov 18, 17:06