User Details
User Details
- User Since
- Jun 12 2024, 16:34 (31 w, 2 d)
Thu, Jan 16
Thu, Jan 16
roqqit committed rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime (authored by roqqit).
[test] Make test_getpeerinfo more robust by using mocktime
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Remove errant newline
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Use assert_equal
Wed, Jan 15
Wed, Jan 15
roqqit committed rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
[test] Fix intermittent timeouts in various functional tests
roqqit committed rABC4b8c65801635: test: Fail if connect_nodes fails (authored by laanwj <126646+laanwj@users.noreply.github.com>).
test: Fail if connect_nodes fails
roqqit committed rABCc801d8fc621a: [test] Cleanup unnecessary sync_all in rpc_net.py (authored by roqqit).
[test] Cleanup unnecessary sync_all in rpc_net.py
roqqit committed rABC7878d95a0db2: [test] clarify rpc_net & p2p_disconnect_ban functional tests (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[test] clarify rpc_net & p2p_disconnect_ban functional tests
roqqit requested review of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.
Fix wait_until_helper -> self.wait_until
roqqit added inline comments to D17530: test: Fail if connect_nodes fails.
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
roqqit requested review of D17538: [test] Make test_getpeerinfo more robust by using mocktime.
roqqit updated the summary of D17530: test: Fail if connect_nodes fails.
roqqit updated the diff for D17530: test: Fail if connect_nodes fails.
Add back accidentally deleted comment
roqqit requested review of D17531: [test] Fix intermittent timeouts in various functional tests.
roqqit requested review of D17530: test: Fail if connect_nodes fails.
roqqit requested review of D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Mon, Jan 13
Mon, Jan 13
roqqit committed rABC1c0e73e93ef7: [avalanche] Set vote status for highest ranking contender (authored by roqqit).
[avalanche] Set vote status for highest ranking contender
roqqit committed rABCbadfc35a942d: [avalanche] Simplify lock into one-liner in processor_tests (authored by roqqit).
[avalanche] Simplify lock into one-liner in processor_tests
roqqit requested review of D17525: [avalanche] Set vote status for highest ranking contender.
roqqit requested review of D17524: [avalanche] Simplify lock into one-liner in processor_tests.
Fri, Jan 10
Fri, Jan 10
roqqit committed rABCe9b4cbef3b43: [avalanche] Set all local stake winners as accepted contenders (authored by roqqit).
[avalanche] Set all local stake winners as accepted contenders
roqqit updated the diff for D17503: [avalanche] Set all local stake winners as accepted contenders.
Bump mocktime beyond the max registration time so there is not a bunch of flaky winners in the functional test
roqqit planned changes to D17503: [avalanche] Set all local stake winners as accepted contenders.
roqqit requested review of D17503: [avalanche] Set all local stake winners as accepted contenders.
Thu, Jan 9
Thu, Jan 9
roqqit committed rABC073bfa519c06: [avalanche] Re-sort pollable contenders by reward rank (authored by roqqit).
[avalanche] Re-sort pollable contenders by reward rank
roqqit updated the diff for D17498: [avalanche] Re-sort pollable contenders by reward rank.
Reuse numPollable
Wed, Jan 8
Wed, Jan 8
roqqit requested review of D17498: [avalanche] Re-sort pollable contenders by reward rank.
roqqit committed rABC11d2e76dd3c3: [avalanche] Refactor reward ranking logic into its own comparator (authored by roqqit).
[avalanche] Refactor reward ranking logic into its own comparator
roqqit updated the diff for D17495: [avalanche] Refactor reward ranking logic into its own comparator.
Fix circular dependency
roqqit requested review of D17495: [avalanche] Refactor reward ranking logic into its own comparator.
roqqit committed rABC53d16b29628d: [avalanche] Add a way to get pollable contenders from contender cache (authored by roqqit).
[avalanche] Add a way to get pollable contenders from contender cache
Tue, Jan 7
Tue, Jan 7
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Cleanup unnecessary nesting when sorting contenders and make the sorting work the same as staking rewards selection.
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.
- Fix rare sorting case where two proofs have the same rank.
- Make num pollable a parameter so the processor will have control over how many contenders to poll for.
- Return number of contenders instead of bool.
- Fix test not actually checking the contender order.
Mon, Jan 6
Mon, Jan 6
roqqit updated the diff for D17479: [avalanche] Add a way to get pollable contenders from contender cache.
Move static_assert to processor.h in order to avoid circular dependency
roqqit requested review of D17479: [avalanche] Add a way to get pollable contenders from contender cache.
roqqit committed rABC576d79f82e1a: [avalanche] Make ComputeProofRewardRank const (authored by roqqit).
[avalanche] Make ComputeProofRewardRank const
roqqit requested review of D17475: [avalanche] Make ComputeProofRewardRank const.
Sat, Dec 21
Sat, Dec 21
roqqit committed rABCefbf025838b6: test: Avoid race after connect_nodes (authored by MarcoFalke <falke.marco@gmail.com>).
test: Avoid race after connect_nodes
Fri, Dec 20
Fri, Dec 20
roqqit requested review of D17381: test: Avoid race after connect_nodes.
Thu, Dec 19
Thu, Dec 19
roqqit committed rABC7f213483007a: Fix flakiness in tests that wait for peer info to update immediately after… (authored by roqqit).
Fix flakiness in tests that wait for peer info to update immediately after…
Dec 18 2024
Dec 18 2024
roqqit committed rABCb1cea59f8291: [avalanche] Set local stake winner in the contender cache (authored by roqqit).
[avalanche] Set local stake winner in the contender cache
roqqit committed rABC607be5e6570a: Fix race to check chaintips in p2p_headers_sync_with_minchainwork (authored by roqqit).
Fix race to check chaintips in p2p_headers_sync_with_minchainwork
roqqit committed rABC0657e8a86eeb: [avalanche] Make sure each proof is added to contender cache before mining the… (authored by roqqit).
[avalanche] Make sure each proof is added to contender cache before mining the…
roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
roqqit updated the diff for D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
- just use getStakeContenderStatus instead of a new accessor
- hasstakecontender -> getstakecontendervote per feedback
- pass in prevblockhash and proofid instead of stakecontenderid
roqqit updated the diff for D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
feedback
Dec 17 2024
Dec 17 2024
roqqit requested review of D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
[seeder] Bump thread stacksize
roqqit retitled D17349: [seeder] Bump thread stacksize from [seeder] Respect resource limit for stacksize as set by the system to [seeder] Bump thread stacksize.
roqqit updated the diff for D17349: [seeder] Bump thread stacksize.
Just bump the value because predicting it is proving to be difficult and time consuming
Dec 16 2024
Dec 16 2024
roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
roqqit updated the diff for D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Use a debug RPC. Waiting for getavalanchepeerinfo is not sufficient here because its possible for this value to be updated before the contender is added to the cache.
Dec 13 2024
Dec 13 2024
roqqit committed rABC200513e58adb: [seeder] Return an error when thread creation fails (authored by roqqit).
[seeder] Return an error when thread creation fails
[seeder] Reword outdated note in readme
roqqit requested review of D17350: [seeder] Reword outdated note in readme.
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
roqqit requested review of D17349: [seeder] Bump thread stacksize.
roqqit updated the test plan for D17349: [seeder] Bump thread stacksize.
roqqit planned changes to D17348: [seeder] Return an error when thread creation fails.
roqqit planned changes to D17349: [seeder] Bump thread stacksize.
roqqit requested review of D17349: [seeder] Bump thread stacksize.
roqqit requested review of D17348: [seeder] Return an error when thread creation fails.
Dec 12 2024
Dec 12 2024
roqqit committed rABC44da17657e7c: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup (authored by roqqit).
[avalanche] Restrict scope of cs_stakingRewards lock during cleanup
Dec 11 2024
Dec 11 2024
roqqit requested review of D17337: [avalanche] Set local stake winner in the contender cache.
roqqit requested review of D17336: [avalanche] Restrict scope of cs_stakingRewards lock during cleanup.
Dec 10 2024
Dec 10 2024
roqqit committed rABCe9d7a6220c01: Add symlink to most recent functional test failure directory (authored by roqqit).
Add symlink to most recent functional test failure directory
roqqit committed rABC8917a6f8af6c: Run more functional tests in parallel by default (authored by roqqit).
Run more functional tests in parallel by default
roqqit updated the test plan for D17331: Add symlink to most recent functional test failure directory.
roqqit updated the diff for D17331: Add symlink to most recent functional test failure directory.
- move lastfailure to top of build_dir
- ignore OSError exceptions on windows (didn't use contextlib.suppress because I don't think we should ignore it on Linux)