roqqit (Roqqit)
User

Projects

User does not belong to any projects.

User Details

User Since: Jun 12 2024, 16:34 (46 w, 3 d)

Recent Activity
View All

Thu, May 1

roqqit abandoned D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Thu, May 1, 19:37

roqqit accepted D18004: [avalanche] Delay polling the conflicting transactions.

I see

Thu, May 1, 19:36

roqqit closed D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Thu, May 1, 18:22

roqqit committed rABC029da727864b: [avalanche] Fix incomplete testing of contenders when staking rewards are active (authored by Fabien).

[avalanche] Fix incomplete testing of contenders when staking rewards are active

Thu, May 1, 18:22

teamcity awarded D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active a Doubloon token.

Thu, May 1, 17:30

roqqit updated the diff for D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

cleanup remaining issues from old draft

Thu, May 1, 17:25

roqqit commandeered D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Thu, May 1, 17:24

roqqit requested changes to D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Thu, May 1, 16:11

roqqit accepted D18033: [test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting.

Thu, May 1, 16:04

roqqit accepted D18040: [test] Only activate the quorum after all the peers are connected.

Thu, May 1, 15:58

roqqit accepted D18039: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting.

Thu, May 1, 15:57

roqqit accepted D18038: [test] Vote unknown for the elements we don't care in abc_p2p_avalanche_contender_voting.

Thu, May 1, 15:53

roqqit accepted D18037: [test] Don't assume the proof score in abc_p2p_avalanche_contender_voting.

Thu, May 1, 15:52

Wed, Apr 30

roqqit accepted D18028: Properly check the node polls for contenders upon restart with no prior block being mined.

Wed, Apr 30, 18:56

roqqit accepted D18026: test: p2p: remove tests for header messages that are oversized due to the MAX_HEADERS_RESULTS limit.

Wed, Apr 30, 16:28

roqqit accepted D18025: test: p2p: check misbehavior for non-continuous headers messages.

Wed, Apr 30, 16:18

roqqit accepted D18024: test: p2p: check that headers message with invalid proof-of-work disconnects peer.

Wed, Apr 30, 16:16

roqqit added inline comments to D18028: Properly check the node polls for contenders upon restart with no prior block being mined.

Wed, Apr 30, 16:01

roqqit requested changes to D18028: Properly check the node polls for contenders upon restart with no prior block being mined.

Wed, Apr 30, 15:59

roqqit closed D18022: [avalanche] Fix dangling proof flakiness in contender test.

Wed, Apr 30, 15:47

roqqit committed rABC2568103e82b9: [avalanche] Fix dangling proof flakiness in contender test (authored by roqqit).

[avalanche] Fix dangling proof flakiness in contender test

Wed, Apr 30, 15:47

roqqit accepted D18027: Fix a race in abc_p2p_avalanche_contender_voting.py.

Wed, Apr 30, 15:44

roqqit updated the summary of D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Wed, Apr 30, 04:18

roqqit added a comment to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

see updated summary. skipping the end of the test is not ideal but it is unclear how much investigation that last piece will take. on the other hand, fixing the flakiness in the rest of the test ensures we are not regressing on the majority of contenders logic. CI deserves to be green again.

Wed, Apr 30, 04:17

roqqit requested review of D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Wed, Apr 30, 04:15

roqqit updated the summary of D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Wed, Apr 30, 04:14

teamcity awarded D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active a Doubloon token.

Wed, Apr 30, 03:33

roqqit added a comment to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

@bot build-master

Wed, Apr 30, 03:33

roqqit planned changes to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Wed, Apr 30, 03:32

roqqit updated the diff for D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

fix various flakiness issues

Wed, Apr 30, 03:32

Tue, Apr 29

roqqit requested review of D18022: [avalanche] Fix dangling proof flakiness in contender test.

Tue, Apr 29, 23:16

roqqit closed D18013: [avalanche] Only re-add contenders to the cache if the remote proof is present.

Tue, Apr 29, 18:53

roqqit committed rABC8ebbda579e21: [avalanche] Only re-add contenders to the cache if the remote proof is present (authored by roqqit).

[avalanche] Only re-add contenders to the cache if the remote proof is present

Tue, Apr 29, 18:53

roqqit closed D18011: [avalanche] Correctly check if a contender is associated with a remote proof.

Tue, Apr 29, 18:48

roqqit committed rABC4a35b7c33298: [avalanche] Correctly check if a contender is associated with a remote proof (authored by roqqit).

[avalanche] Correctly check if a contender is associated with a remote proof

Tue, Apr 29, 18:48

roqqit updated the diff for D18011: [avalanche] Correctly check if a contender is associated with a remote proof.

address feedback

Tue, Apr 29, 17:11

roqqit added inline comments to D18011: [avalanche] Correctly check if a contender is associated with a remote proof.

Tue, Apr 29, 17:10

roqqit committed rABC209972a1e872: [test] Call out missing messages when asserting the debug log (authored by roqqit).

[test] Call out missing messages when asserting the debug log

Tue, Apr 29, 16:46

roqqit closed D18009: [test] Call out missing messages when asserting the debug log.

Tue, Apr 29, 16:46

roqqit closed D18012: [avalanche] Also log when contenders are not promoted.

Tue, Apr 29, 16:43

roqqit committed rABC5d39d807f0a9: [avalanche] Also log when contenders are not promoted (authored by roqqit).

[avalanche] Also log when contenders are not promoted

Tue, Apr 29, 16:43

roqqit committed rABC58a4750550e8: [avalanche] Rename isRemoteProof to hasRemoteProofStatus (authored by roqqit).

[avalanche] Rename isRemoteProof to hasRemoteProofStatus

Tue, Apr 29, 16:42

roqqit closed D18010: [avalanche] Rename isRemoteProof to hasRemoteProofStatus.

Tue, Apr 29, 16:42

Mon, Apr 28

roqqit requested review of D18013: [avalanche] Only re-add contenders to the cache if the remote proof is present.

Mon, Apr 28, 23:53

roqqit requested review of D18012: [avalanche] Also log when contenders are not promoted.

Mon, Apr 28, 23:47

roqqit requested review of D18011: [avalanche] Correctly check if a contender is associated with a remote proof.

Mon, Apr 28, 23:18

roqqit requested review of D18010: [avalanche] Rename isRemoteProof to hasRemoteProofStatus.

Mon, Apr 28, 22:23

roqqit committed rABC7f65b6a8f20e: [test] Pretty print expected messages when asserting a debug log (authored by roqqit).

[test] Pretty print expected messages when asserting a debug log

Mon, Apr 28, 22:16

roqqit closed D18008: [test] Pretty print expected messages when asserting a debug log.

Mon, Apr 28, 22:16

roqqit closed D18007: [test] Swap debug log and expected messages error string.

Mon, Apr 28, 22:16

roqqit committed rABC645747705d1f: [test] Swap debug log and expected messages error string (authored by roqqit).

[test] Swap debug log and expected messages error string

Mon, Apr 28, 22:16

roqqit added inline comments to D18009: [test] Call out missing messages when asserting the debug log.

Mon, Apr 28, 21:39

roqqit requested changes to D18004: [avalanche] Delay polling the conflicting transactions.

Mon, Apr 28, 20:11

roqqit updated the diff for D18009: [test] Call out missing messages when asserting the debug log.

pretty print missing messages too

Mon, Apr 28, 19:41

roqqit updated the diff for D18009: [test] Call out missing messages when asserting the debug log.

rebase

Mon, Apr 28, 19:32

roqqit updated the diff for D18008: [test] Pretty print expected messages when asserting a debug log.

rebase

Mon, Apr 28, 19:30

roqqit updated the diff for D18007: [test] Swap debug log and expected messages error string.

It turns out I did break them

Mon, Apr 28, 19:28

roqqit requested review of D18009: [test] Call out missing messages when asserting the debug log.

Mon, Apr 28, 19:20

roqqit added a comment to D18007: [test] Swap debug log and expected messages error string.

Both failures appear to be I2P related. I don't think it was this diff that triggered the failures.

Mon, Apr 28, 18:48

roqqit requested review of D18008: [test] Pretty print expected messages when asserting a debug log.

Mon, Apr 28, 18:46

roqqit requested review of D18007: [test] Swap debug log and expected messages error string.

Mon, Apr 28, 18:21

Sun, Apr 27

roqqit planned changes to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Sun, Apr 27, 03:00

teamcity awarded D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active a Piece of Eight token.

Sun, Apr 27, 03:00

roqqit added a comment to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

@bot build-master

Sun, Apr 27, 03:00

roqqit updated the test plan for D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Sun, Apr 27, 02:07

teamcity awarded D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active a Haypence token.

Sun, Apr 27, 02:06

roqqit added a comment to D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

@bot build-master

Sun, Apr 27, 02:06

roqqit requested review of D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Sun, Apr 27, 02:05

Sat, Apr 26

roqqit closed D17997: [avalanche] Fix staking reward flakiness after node restart in contenders test.

Sat, Apr 26, 20:50

roqqit committed rABC8ed7061ec857: [avalanche] Fix staking reward flakiness after node restart in contenders test (authored by roqqit).

[avalanche] Fix staking reward flakiness after node restart in contenders test

Sat, Apr 26, 20:50

Fri, Apr 25

roqqit requested review of D17997: [avalanche] Fix staking reward flakiness after node restart in contenders test.

Fri, Apr 25, 20:13

roqqit closed D17986: [avalanche] Promote and poll contenders as soon as quorum is active.

Fri, Apr 25, 17:33

roqqit committed rABCe11cfb3ca8eb: [avalanche] Promote and poll contenders as soon as quorum is active (authored by roqqit).

[avalanche] Promote and poll contenders as soon as quorum is active

Fri, Apr 25, 17:33

Thu, Apr 24

roqqit updated the diff for D17986: [avalanche] Promote and poll contenders as soon as quorum is active.

feedback

Thu, Apr 24, 21:47

roqqit closed D17993: [avalanche] Refactor proof rank calculation in functional test.

Thu, Apr 24, 21:27

roqqit committed rABCda39027ba95c: [avalanche] Refactor proof rank calculation in functional test (authored by roqqit).

[avalanche] Refactor proof rank calculation in functional test

Thu, Apr 24, 21:27

roqqit requested review of D17993: [avalanche] Refactor proof rank calculation in functional test.

Thu, Apr 24, 19:15

Wed, Apr 23

roqqit requested review of D17986: [avalanche] Promote and poll contenders as soon as quorum is active.

Wed, Apr 23, 21:44

roqqit closed D17983: [avalanche] Prevent regressions in the case that promotion happens twice for a block.

Wed, Apr 23, 21:10

roqqit committed rABCec671e1e6767: [avalanche] Prevent regressions in the case that promotion happens twice for a… (authored by roqqit).

[avalanche] Prevent regressions in the case that promotion happens twice for a…

Wed, Apr 23, 21:10

roqqit requested review of D17983: [avalanche] Prevent regressions in the case that promotion happens twice for a block.

Wed, Apr 23, 17:23

roqqit closed D17972: [doc] Add productivity note about utilizing the ramdisk for faster testing.

Wed, Apr 23, 17:01

roqqit committed rABC79f659739aab: [doc] Add productivity note about utilizing the ramdisk for faster testing (authored by roqqit).

[doc] Add productivity note about utilizing the ramdisk for faster testing

Wed, Apr 23, 17:00

Tue, Apr 22

roqqit requested review of D17972: [doc] Add productivity note about utilizing the ramdisk for faster testing.

Tue, Apr 22, 22:54

roqqit accepted D17969: [CI] Add a --ramdisk option to CI to store the regtest blockchain.

Tue, Apr 22, 22:41

roqqit accepted D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

Tue, Apr 22, 16:26

Fri, Apr 11

roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.

Fri, Apr 11, 15:41

roqqit closed D17923: [avalanche] Wait for the local winner instead of immediately asserting.

Fri, Apr 11, 15:25

roqqit committed rABCc50432fcd1a8: [avalanche] Wait for the local winner instead of immediately asserting (authored by roqqit).

[avalanche] Wait for the local winner instead of immediately asserting

Fri, Apr 11, 15:25

Thu, Apr 10

roqqit requested review of D17923: [avalanche] Wait for the local winner instead of immediately asserting.

Thu, Apr 10, 23:41

roqqit closed D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.

Thu, Apr 10, 21:21

roqqit committed rABCe0776c77fd38: [avalanche] Remove requirement that local staking rewards have to be computed… (authored by roqqit).

[avalanche] Remove requirement that local staking rewards have to be computed…

Thu, Apr 10, 21:21

roqqit accepted D17920: test: run feature_pruning.py without wallet compiled.

Thu, Apr 10, 21:15

roqqit added inline comments to D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.

Thu, Apr 10, 18:04

Wed, Apr 9

roqqit requested review of D17917: [avalanche] Remove requirement that local staking rewards have to be computed in order to poll contenders.

Wed, Apr 9, 22:22

roqqit accepted D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.

Wed, Apr 9, 16:37

roqqit accepted D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.

Wed, Apr 9, 16:34

roqqit closed D17912: Add Shibusawa activation logic.

Wed, Apr 9, 15:43

roqqit committed rABC8b148e37eb56: Add Shibusawa activation logic (authored by roqqit).

Add Shibusawa activation logic

Wed, Apr 9, 15:43

Tue, Apr 8

roqqit requested review of D17912: Add Shibusawa activation logic.

Tue, Apr 8, 18:52