Page MenuHomePhabricator
Differential D1173

Remove mempool dependency on minRelayFee
ClosedPublic
Actions

Authored by schancel on Mar 5 2018, 23:34.

Details

Reviewers
deadalnix
jasonbcox
sickpig
matiu
Group Reviewers
Restricted Project
Commits
rSTAGINGf8181f403973: Remove mempool dependency on minRelayFee
rABCf8181f403973: Remove mempool dependency on minRelayFee
Summary

As per title, this dependency does not seem to actually be used
for anything meaningful.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mempool-minfee
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2005
Build 2158: Bitcoin ABC Buildbot (legacy)
Build 2157: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 5 2018, 23:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2018, 23:34
teamcity added a subscriber: teamcity.Mar 6 2018, 00:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 00:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2005: Diff 3091.Mar 6 2018, 00:55
jasonbcox accepted this revision.Mar 6 2018, 04:19
This revision is now accepted and ready to land.Mar 6 2018, 04:19
schancel edited the summary of this revision. (Show Details)Mar 6 2018, 05:55
schancel updated this revision to Diff 3095.Mar 6 2018, 06:26

Rebase

teamcity added a comment.Mar 6 2018, 06:28

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 06:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2009: Diff 3095.Mar 6 2018, 06:52
schancel removed a parent revision: D962: Prepare a flag for charging for excessive utxo creation.Mar 7 2018, 19:10
schancel added a comment.Mar 13 2018, 18:23

This will be scheduled for 0.17.1 So we can check the effect on the BlockPolicyEstimator.

schancel added a task: T287: Release 0.17.1 Inclusions.Mar 13 2018, 18:25
schancel added a child revision: D1361: Move minRelayFee into Config handler.May 3 2018, 00:23
Closed by commit rABCf8181f403973: Remove mempool dependency on minRelayFee (authored by schancel). · Explain WhyMay 3 2018, 01:16
This revision was automatically updated to reflect the committed changes.
schancel removed a task: T287: Release 0.17.1 Inclusions.May 3 2018, 01:32

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
policy/
3 lines
5 lines
test/
8 lines
10 lines
2 lines
2 lines
5 lines
2 lines

Diff 3091

View Options

src/bench/mempool_eviction.cpp

Loading...
View Options

src/policy/fees.h

Loading...
View Options

src/policy/fees.cpp

Loading...
View Options

src/test/blockencodings_tests.cpp

Loading...
View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/test/policyestimator_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...