Page MenuHomePhabricator
Differential D1182

Added and fixed up comments in validation.cpp
ClosedPublic
Actions

Authored by jasonbcox on Mar 6 2018, 22:08.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9dd5095b9380: Added and fixed up comments in validation.cpp
rABC9dd5095b9380: Added and fixed up comments in validation.cpp
Summary

Adding comments in validation.cpp helps me. Hopefully it helps everyone else as well.

Test Plan

N/A

Diff Detail

Repository
rABC Bitcoin ABC
Branch
comments
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2028
Build 2204: Bitcoin ABC Buildbot (legacy)
Build 2203: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 6 2018, 22:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2018, 22:08
teamcity added a subscriber: teamcity.Mar 6 2018, 22:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 6 2018, 22:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2020: Diff 3116.Mar 6 2018, 22:30
schancel accepted this revision.Mar 7 2018, 06:37
This revision is now accepted and ready to land.Mar 7 2018, 06:37
deadalnix added inline comments.Mar 7 2018, 14:05
src/validation.cpp
3339 ↗(On Diff #3116)

The comment for non static method should go in the header.

jasonbcox updated this revision to Diff 3128.Mar 8 2018, 02:48

Moved non-static function comments to validation.h

jasonbcox requested review of this revision.Mar 8 2018, 02:49
teamcity added a comment.Mar 8 2018, 02:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 8 2018, 03:11

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2028: Diff 3128.Mar 8 2018, 03:11
schancel accepted this revision.Mar 8 2018, 04:30
This revision is now accepted and ready to land.Mar 8 2018, 04:30
Closed by commit rABC9dd5095b9380: Added and fixed up comments in validation.cpp (authored by jasonbcox). · Explain WhyMar 8 2018, 21:13
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.Apr 4 2019, 18:20
nakihito mentioned this in D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.Sep 10 2019, 20:18
deadalnix mentioned this in D4045: Revert change to ActivateBestChain() comments made in D1182.Sep 12 2019, 14:15
Nico Guiton <nico@bitframe.org> mentioned this in rABC62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182.Sep 19 2019, 20:29
nakihito mentioned this in D4138: Revert change to PreciousBlock() comment made in D1182.Sep 23 2019, 17:41
Nico Guiton <nico@bitframe.org> mentioned this in rABCc9da74332c34: Revert change to PreciousBlock() comment made in D1182.Sep 23 2019, 22:17
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGING62ec58375ca4: Revert change to ActivateBestChain() comments made in D1182.Sep 27 2019, 22:45
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGc9da74332c34: Revert change to PreciousBlock() comment made in D1182.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
src/
28 lines
20 lines

Diff 3128

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...