Page MenuHomePhabricator
Differential D16707

[electrum] remove ecdsa as a direct dependency
ClosedPublic
Actions

Authored by PiRK on Sep 3 2024, 10:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC752fbaadbcf4: [electrum] remove ecdsa as a direct dependency
Summary

This completes the work on removing the ecdsa dependency

It might still be needed indirectly as a dependency of a dependency (btchip-python, pystaochip.... require it).
Depends on D16705

Test Plan

with and without the python ecdsa lib installed :

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_crypto
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30175
Build 59879: Build Diffelectrum-tests
Build 59878: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 3 2024, 10:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2024, 10:44
PiRK published this revision for review.Sep 3 2024, 10:48

@bot electrum-functional-tests

teamcity awarded a token.Sep 3 2024, 10:48
Harbormaster completed remote builds in B30161: Diff 49458.Sep 3 2024, 11:02
Fabien accepted this revision.Sep 4 2024, 08:44
This revision is now accepted and ready to land.Sep 4 2024, 08:44
PiRK updated this revision to Diff 49475.Sep 4 2024, 10:04
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D16705: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg).

rebase after squashing D16706 with previous diffs

PiRK removed a parent revision: D16706: [electrum] hard fail if libsecp256k1 is not found/usable.Sep 4 2024, 10:09
Harbormaster completed remote builds in B30173: Diff 49475.Sep 4 2024, 10:24
PiRK updated this revision to Diff 49477.Sep 4 2024, 13:49

improve error message some more

PiRK updated this revision to Diff 49479.Sep 4 2024, 13:52

rebase

Harbormaster completed remote builds in B30175: Diff 49477.Sep 4 2024, 14:06
Harbormaster completed remote builds in B30177: Diff 49479.
Closed by commit rABC752fbaadbcf4: [electrum] remove ecdsa as a direct dependency (authored by PiRK). · Explain WhySep 5 2024, 06:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC752fbaadbcf4: [electrum] remove ecdsa as a direct dependency.

Revision Contents
Changeset List

PathSize
electrum/
contrib/
deterministic-build/
3 lines
requirements/
1 line
1 line
electrumabc/
3 lines
tests/
8 lines

Diff 49477

View Options

electrum/contrib/deterministic-build/requirements.txt

Loading...
View Options

electrum/contrib/requirements/requirements.txt

Loading...
View Options

electrum/electrum-abc

Loading...
View Options

electrum/electrumabc/secp256k1.py

Loading...
View Options

electrum/electrumabc/tests/test_schnorr.py

Loading...