Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING03d6d3b49d9c: Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once…
rABC03d6d3b49d9c: Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once…

Summary

As per title. Right now we reject them always.

Test Plan

Added test cases in abc-p2p-activation.py to ensure the transaction is accepted properly in the mempool.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 15 2017, 23:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2017, 23:55

Harbormaster completed remote builds in B308: Diff 506.Jun 15 2017, 23:55

test the first block at activation rather than after piling up one block

Harbormaster completed remote builds in B309: Diff 507.Jun 15 2017, 23:58

Diverse nits and tweaks

Harbormaster completed remote builds in B310: Diff 508.Jun 16 2017, 00:06

deadalnix added a child revision: D213: Test HF activation accross reorg.Jun 16 2017, 10:27

freetrader accepted this revision.Jun 16 2017, 12:14

freetrader added inline comments.

qa/rpc-tests/abc-p2p-activation.py
21 ↗	(On Diff #508)	Rrror -> Error
52 ↗	(On Diff #508)	Could you briefly describe why it was necessary to add this into the test?

This revision is now accepted and ready to land.Jun 16 2017, 12:14

deadalnix added inline comments.Jun 16 2017, 12:16

qa/rpc-tests/abc-p2p-activation.py
52 ↗	(On Diff #508)	Because when not passing it, the transaction must respect the fee policy of the node to be included in the mempool. I don't want this test to be breaking because the fee policy code was changed and I don't want to tweak transactions in such a way they have to respect the fee policy.

Rebase and fix merge conflicts

Harbormaster completed remote builds in B322: Diff 525.Jun 16 2017, 13:12

Reintroduce -norelaypriority

Harbormaster completed remote builds in B324: Diff 527.Jun 16 2017, 13:21

Closed by commit rABC03d6d3b49d9c: Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once… (authored by deadalnix, committed by deadalnix). · Explain WhyJun 16 2017, 13:21

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in T36: Ensure SIGHASH_FORKID is accepted/rejected from the mempool at apropriate time..Jun 19 2017, 21:10

Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once the HF activates
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 528

qa/rpc-tests/abc-p2p-activation.py

qa/rpc-tests/test_framework/script.py

src/test/mempool_tests.cpp

src/validation.cpp

Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once the HF activatesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 528

qa/rpc-tests/abc-p2p-activation.py

qa/rpc-tests/test_framework/script.py

src/test/mempool_tests.cpp

src/validation.cpp

Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once the HF activates
ClosedPublic
Actions

Revision Contents
Changeset List