Page MenuHomePhabricator
Differential D2358

[tests] Tidy up mininode
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 09:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf3a7d2f8ef59: [tests] Tidy up mininode
rABCf3a7d2f8ef59: [tests] Tidy up mininode
Summary

Add docstrings and renames some methods.
Also removes the redundant NodeConn.readable() method override.

Partial backport of core PR11712 (commit 4d50598)

Depend on D2357

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 09:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 09:09
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 21 2019, 09:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2359: [tests] Move only: move NodeConnCB below NodeConn.Jan 21 2019, 09:16
teamcity added a comment.Jan 21 2019, 09:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4602: Diff 6772!Jan 21 2019, 09:20
teamcity added a comment.Jan 21 2019, 09:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 21 2019, 09:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4602: Diff 6772.Jan 21 2019, 09:52
deadalnix requested changes to this revision.Jan 21 2019, 17:02
deadalnix added inline comments.
test/functional/test_framework/mininode.py
336 ↗(On Diff #6772)

This wasn't backported properly.

This revision now requires changes to proceed.Jan 21 2019, 17:02
Fabien requested review of this revision.Jan 21 2019, 17:58
Fabien added inline comments.
test/functional/test_framework/mininode.py
336 ↗(On Diff #6772)

This doesn't match exactly the PR because the I kept the mechanism introduced in D284. In this case the message is returned.

deadalnix accepted this revision.Jan 21 2019, 18:03
This revision is now accepted and ready to land.Jan 21 2019, 18:03
Closed by commit rABCf3a7d2f8ef59: [tests] Tidy up mininode (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 21 2019, 19:14
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T471: Backport Core PR11712.Jul 7 2019, 17:06
Fabien added a commit: rSTAGINGf3a7d2f8ef59: [tests] Tidy up mininode.Sep 18 2019, 21:59

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
35 lines

Diff 6794

View Options

test/functional/test_framework/mininode.py

Loading...