Create new mutex for orphans, no cs_main in PLV::BlockConnected
ClosedPublic
Actions

Authored by Fabien on Feb 26 2019, 10:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8e27b02b0cfd: Create new mutex for orphans, no cs_main in PLV::BlockConnected
rABC8e27b02b0cfd: Create new mutex for orphans, no cs_main in PLV::BlockConnected

Summary

This should (marginally) speed up validationinterface queue
draining by avoiding a cs_main lock in one client.

Partial backport of core PR11824 (commit 818075a)

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11824_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5069
Build 8201: Bitcoin ABC Buildbot (legacy)
Build 8200: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 26 2019, 10:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 10:21

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5069: Diff 7479.Feb 26 2019, 10:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a child revision: D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.Feb 26 2019, 10:38

That is a very good backport.

This revision is now accepted and ready to land.Feb 26 2019, 17:07

Closed by commit rABC8e27b02b0cfd: Create new mutex for orphans, no cs_main in PLV::BlockConnected (authored by Matt Corallo <git@bluematt.me>, committed by Fabien). · Explain WhyFeb 27 2019, 07:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING8e27b02b0cfd: Create new mutex for orphans, no cs_main in PLV::BlockConnected.Sep 18 2019, 22:33

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

39 lines

Diff 7479

View Options

Create new mutex for orphans, no cs_main in PLV::BlockConnectedClosedPublicActions