Page MenuHomePhabricator

Add Sent and Received information to the debug menu peer list
ClosedPublic

Authored by nakihito on Tue, Apr 2, 21:55.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc29c9a8522b4: Add Sent and Received information to the debug menu peer list
Summary

Add Sent and Received information to the debug menu peer list

Backport of Core PR11499
https://github.com/bitcoin/bitcoin/pull/11499

Completes T554

Test Plan

bitcoin-qt
Help -> Debug Window -> Peers should display Sent and Received information

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Apr 2, 21:55
Owners added a reviewer: Restricted Owners Package.Tue, Apr 2, 21:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 2, 21:55
Herald added a subscriber: schancel. · View Herald Transcript
nakihito planned changes to this revision.Tue, Apr 2, 21:56
nakihito updated this revision to Diff 7925.Tue, Apr 2, 22:15

Squashed together two commits.

nakihito planned changes to this revision.Tue, Apr 2, 22:15
nakihito requested review of this revision.Tue, Apr 9, 19:33
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
jasonbcox requested changes to this revision.Wed, Apr 10, 20:24
jasonbcox added inline comments.
src/qt/guiutil.cpp
1008 ↗(On Diff #7925)

All three if-statements needs brackets to match our new codestyle. Many backports do not contain them, but we add them for readability and reduced bug introduction risk.

This revision now requires changes to proceed.Wed, Apr 10, 20:24
nakihito updated this revision to Diff 8060.Mon, Apr 15, 16:31

Added braces {} to if statements. Linter did not catch these for some reason?

nakihito marked an inline comment as done.Mon, Apr 15, 16:43
Fabien requested changes to this revision.Tue, Apr 16, 07:54
Fabien added inline comments.
src/qt/rpcconsole.cpp
1290 ↗(On Diff #8060)

Restore

This revision now requires changes to proceed.Tue, Apr 16, 07:54
nakihito updated this revision to Diff 8074.Tue, Apr 16, 17:11

Restored newline.

Fabien accepted this revision.Tue, Apr 16, 19:51
deadalnix accepted this revision.Wed, Apr 17, 12:11
deadalnix added inline comments.
src/qt/peertablemodel.h
60 ↗(On Diff #8074)

trailing coma

jasonbcox accepted this revision.Thu, Apr 18, 15:08
This revision is now accepted and ready to land.Thu, Apr 18, 15:08
nakihito marked an inline comment as done.Fri, Apr 19, 17:57
nakihito updated this revision to Diff 8153.Fri, Apr 19, 18:11

Added trailing comma to ColumnIndex enum.

This revision was automatically updated to reflect the committed changes.