Page MenuHomePhabricator
Differential D2815

Remove direct bitcoin calls from qt/bitcoingui.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 16:49.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp
rABC767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/3d619e9d3658e36cba4a19a5bed33e5538317b27
Progress towards T417
Depends on D2814

Test Plan
make check
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10244-c3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5485
Build 9032: Bitcoin ABC Buildbot (legacy)
Build 9031: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 16:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 16:49
teamcity added a comment.Apr 17 2019, 16:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 8100.Apr 17 2019, 16:53

Rebase

teamcity added a comment.Apr 17 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 17 2019, 17:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5483: Diff 8098.Apr 17 2019, 17:03
deadalnix accepted this revision.Apr 17 2019, 17:05
deadalnix added inline comments.
src/qt/bitcoingui.cpp
38 ↗(On Diff #8098)

You should really not try to fix these. We need to move to angle bracket at some point anyways.

This revision is now accepted and ready to land.Apr 17 2019, 17:05
Harbormaster completed remote builds in B5485: Diff 8100.Apr 17 2019, 17:08
teamcity added a comment.Apr 17 2019, 17:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox added a child revision: D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.Apr 17 2019, 17:12
Closed by commit rABC767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 17 2019, 19:02
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp.Sep 18 2019, 23:00

Revision Contents
Changeset List

PathSize
src/
interface/
15 lines
7 lines
qt/
2 lines
13 lines
20 lines

Diff 8100

View Options

src/interface/node.h

Loading...
View Options

src/interface/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...