Page MenuHomePhabricator
Differential D297

Make a copy of PrecomputedTransactionData in the CScriptCheck
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2017, 16:54.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGINGf4f64ae534f2: Make a copy of PrecomputedTransactionData in the CScriptCheck
rABCf4f64ae534f2: Make a copy of PrecomputedTransactionData in the CScriptCheck
Summary

This ensure that each CScriptCheck has its own PrecomputedTransactionData which makes consideration about multithreading irrelevent to the outside world.

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txcache
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 455
Build 455: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2017, 16:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2017, 16:54
Harbormaster completed remote builds in B455: Diff 736.Jul 4 2017, 16:54
kyuupichan accepted this revision.Jul 6 2017, 12:19

Looks good to me but I'n not an expert in this part of the codebase.

This revision is now accepted and ready to land.Jul 6 2017, 12:19
Closed by commit rABCf4f64ae534f2: Make a copy of PrecomputedTransactionData in the CScriptCheck (authored by deadalnix, committed by deadalnix). · Explain WhyJul 6 2017, 14:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
primitives/
14 lines
script/
8 lines
test/
2 lines
17 lines
23 lines

Diff 736

View Options

src/checkqueue.h

Loading...
View Options

src/primitives/transaction.h

Loading...
View Options

src/script/interpreter.h

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...