Add help text for uahfstarttime command line option
ClosedPublic
Actions

Authored by freetrader on Jul 13 2017, 14:15.

Details

Reviewers

deadalnix
sickpig
awemany
Mengerian
CCulianu
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING3e00cdcc48c6: Add help text for uahfstarttime command line option
rABC3e00cdcc48c6: Add help text for uahfstarttime command line option

Summary

Adds a help text that also shows default value.

Test Plan

make check

Run 'src/bitcoind --help' and check uahfstartttime description.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add_uahfstartttime_help

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 496
Build 496: arc lint + arc unit

Event Timeline

freetrader created this revision.Jul 13 2017, 14:15

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 13 2017, 14:15

Harbormaster completed remote builds in B496: Diff 798.Jul 13 2017, 14:15

It's missing a note about setting start time to 0, if implemented.

From spec:

NOTE 1: Configuring a "activation time" value of zero (0) shall disable any UAHF hard fork special rules (see REQ-DISABLE)

This revision now requires changes to proceed.Jul 13 2017, 16:44

My understanding is that REQ-DISABLE is not implemented at this stage.

T54 is open.

As long as there is a task tracking this, I think we are good here.

@freetrader you should request review in these cases, because that's unclear that further review is required here.

dagurval accepted this revision.Jul 13 2017, 18:24

This revision is now accepted and ready to land.Jul 13 2017, 18:24

Closed by commit rABC3e00cdcc48c6: Add help text for uahfstarttime command line option (authored by freetrader, committed by freetrader). · Explain WhyJul 13 2017, 21:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

7 lines

Diff 798

View Options

Add help text for uahfstarttime command line optionClosedPublicActions