add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
ClosedPublic
Actions

Authored by markblundeberg on Jun 29 2019, 21:13.

Details

Reviewers

deadalnix
Mengerian
jasonbcox
Fabien

Group Reviewers

Restricted Project

Maniphest Tasks

T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)

Commits

rSTAGING30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
rABC30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode

Summary

Additionally, a variety of tests are included for ensuring legacy
multisig behaviour continues unaltered under the new flag (when dummy=null).

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

newflag

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6723
Build 11493: Bitcoin ABC Buildbot (legacy)
Build 11492: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 29 2019, 21:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2019, 21:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

(I will likely be adding some more tests and I'm open for suggestions as well)

markblundeberg retitled this revision from add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode.Jun 29 2019, 21:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6554: Diff 9799.Jun 29 2019, 21:22

markblundeberg added a child revision: D3474: Implement new checkmultisig trigger logic and execution logic..Jun 29 2019, 21:31

Call it SCHNORR_MULTISIG or something. New multisig is a great name up to the point we need a new new multisig.

We have a new bridge in Paris. It is 900 years old.

This revision now requires changes to proceed.Jun 29 2019, 23:58

We have a new bridge in Paris. It is 900 years old.

lmao, great anecdote. :-)

(Another good one: Amsterdam has both the "Old Church" and "New Church". Indeed the new church is an entire century younger ... but it's still 600 years old)

markblundeberg added a task: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).Jul 1 2019, 06:11