Page MenuHomePhabricator

add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
ClosedPublic

Authored by markblundeberg on Jun 29 2019, 21:13.

Details

Summary

Additionally, a variety of tests are included for ensuring legacy
multisig behaviour continues unaltered under the new flag (when dummy=null).

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(I will likely be adding some more tests and I'm open for suggestions as well)

markblundeberg retitled this revision from add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode.Jun 29 2019, 21:20
deadalnix requested changes to this revision.Jun 29 2019, 23:58

Call it SCHNORR_MULTISIG or something. New multisig is a great name up to the point we need a new new multisig.

We have a new bridge in Paris. It is 900 years old.

This revision now requires changes to proceed.Jun 29 2019, 23:58

We have a new bridge in Paris. It is 900 years old.

lmao, great anecdote. :-)

(Another good one: Amsterdam has both the "Old Church" and "New Church". Indeed the new church is an entire century younger ... but it's still 600 years old)

markblundeberg retitled this revision from [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.

update name

This revision is now accepted and ready to land.Jul 8 2019, 14:21