Page MenuHomePhabricator
Differential D3472

add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
ClosedPublic
Actions

Authored by markblundeberg on Jun 29 2019, 21:13.

Details

Reviewers
deadalnix
Mengerian
jasonbcox
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics)
Commits
rSTAGING30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
rABC30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
Summary

Additionally, a variety of tests are included for ensuring legacy
multisig behaviour continues unaltered under the new flag (when dummy=null).

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jun 29 2019, 21:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2019, 21:13
teamcity added a comment.Jun 29 2019, 21:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.Jun 29 2019, 21:20

(I will likely be adding some more tests and I'm open for suggestions as well)

markblundeberg retitled this revision from add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode.Jun 29 2019, 21:20
teamcity added a comment.Jun 29 2019, 21:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6554: Diff 9799.Jun 29 2019, 21:22
markblundeberg added a child revision: D3474: Implement new checkmultisig trigger logic and execution logic..Jun 29 2019, 21:31
deadalnix requested changes to this revision.Jun 29 2019, 23:58

Call it SCHNORR_MULTISIG or something. New multisig is a great name up to the point we need a new new multisig.

We have a new bridge in Paris. It is 900 years old.

This revision now requires changes to proceed.Jun 29 2019, 23:58
markblundeberg added a comment.Jun 30 2019, 01:53

We have a new bridge in Paris. It is 900 years old.

lmao, great anecdote. :-)

(Another good one: Amsterdam has both the "Old Church" and "New Church". Indeed the new church is an entire century younger ... but it's still 600 years old)

markblundeberg added a task: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).Jul 1 2019, 06:11
markblundeberg updated this revision to Diff 10069.Jul 8 2019, 01:01
markblundeberg retitled this revision from [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.

update name

teamcity added a comment.Jul 8 2019, 01:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 8 2019, 01:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6723: Diff 10069.Jul 8 2019, 01:11
deadalnix accepted this revision.Jul 8 2019, 14:21
This revision is now accepted and ready to land.Jul 8 2019, 14:21
Closed by commit rABC30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 16 2019, 20:32
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.Sep 19 2019, 01:18

Revision Contents
Changeset List

PathSize
src/
script/
4 lines
test/
data/
49 lines
82 lines
1 line

Diff 10324

View Options

src/script/script_flags.h

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/scriptflags.cpp

Loading...