Page MenuHomePhabricator

Merge #10347: Use range-based for loops (C++11) when looping over vector elements
ClosedPublic

Authored by nakihito on Jul 1 2019, 19:58.

Details

Summary

211adc0 Use range-based for loops (C++11) when looping over vector elements (practicalswift)

Tree-SHA512: 0e007f20dcef99d3c7a1036265e00f689d69f42e02fd82dd8389f45b52d31947e5f9388de2610d3d9bd9f554915ce0d35ebce561e5ae3a9013956d0ee4937145

Backport of Core PR10347
https://github.com/bitcoin/bitcoin/pull/10347/files

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jul 1 2019, 19:58
Owners added a reviewer: Restricted Owners Package.Jul 1 2019, 19:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 19:58
jasonbcox requested changes to this revision.Jul 1 2019, 20:11
jasonbcox added inline comments.
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Although we're using range-based loops here, it should still be updated to use auto.

This revision now requires changes to proceed.Jul 1 2019, 20:11
nakihito updated this revision to Diff 9874.Jul 1 2019, 20:16

Changed CTxIn to auto.

Fabien added inline comments.Jul 1 2019, 20:45
src/wallet/wallet.cpp
2160 ↗(On Diff #9874)

Why only doing half the backport ? By replacing in with txin you can remove 4 conflicts.

deadalnix added inline comments.Jul 1 2019, 22:53
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Because ?

deadalnix added inline comments.Jul 1 2019, 22:54
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Merge conflict I guess.

nakihito planned changes to this revision.Jul 2 2019, 01:33
nakihito updated this revision to Diff 9944.Jul 3 2019, 00:13

Fixed nits.

nakihito planned changes to this revision.Jul 3 2019, 00:13
nakihito requested review of this revision.Jul 5 2019, 17:55
Fabien accepted this revision.Jul 5 2019, 20:54
Fabien added inline comments.
src/wallet/wallet.cpp
2160 ↗(On Diff #9872)

Yes I meant merge conflict.

jasonbcox accepted this revision.Jul 8 2019, 17:02
This revision is now accepted and ready to land.Jul 8 2019, 17:02