Page MenuHomePhabricator

Merge #12716: Fix typos and cleanup in various files

Authored by nakihito on Aug 5 2019, 22:05.



4d9b4256d8 Fix typos (Dimitris Apostolou)

Pull request description:

Unfortunately I messed up my repo while trying to squash #12593 so I created a PR with just the correct fixes.

Tree-SHA512: 295d77b51bd2a9381f1802c263de7ffb2edd670d9647391e32f9a414705b3c8b483bb0e469a9b85ab6a70919ea13397fa8dfda2aea7a398b64b187f178fe6a06

Backport of Core PR12716

Test Plan
make check
arc lint

Diff Detail

rABC Bitcoin ABC
Lint Passed
No Test Coverage
Build Status
Buildable 7049
Build 12145: Bitcoin ABC Buildbot (legacy)
Build 12144: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 5 2019, 22:05
jasonbcox requested changes to this revision.Aug 5 2019, 22:21
jasonbcox added inline comments.
237 ↗(On Diff #10619)

its -> it is

408 ↗(On Diff #10619)


38 ↗(On Diff #10619)

Add this one to the spellcheck linter

2266 ↗(On Diff #10619)

fix multi-line string

493 ↗(On Diff #10619)

add this one to the linter too

This revision now requires changes to proceed.Aug 5 2019, 22:21

Fixed its and muli-line string. Added new mispellings to dictionary.


The change to workaround was done manually. When the linter attempted to fix this typo, it would replace with Work Around rather than Work around. I do not know whether this is expected or unexpected behavior, but it would have been incorrect regardless.

deadalnix requested changes to this revision.
deadalnix added inline comments.

Workaround is commonly used as a noun:

This is not good.

This revision now requires changes to proceed.Aug 6 2019, 06:16
493 ↗(On Diff #10619)

You don't want to add this one to the linter, because all 3 words (work, around and workaround) are valid.
The linter has no way to get the context and will just replace a valid word by the others under every circumstance, which is not what you want.

I will look at another spell check, maybe in addition to this one, because there are a lot of leftovers and this cause a lot of maintenance.

Reverted workaround change.

jasonbcox requested changes to this revision.Aug 6 2019, 17:20
jasonbcox added inline comments.
2266 ↗(On Diff #10634)


This revision now requires changes to proceed.Aug 6 2019, 17:20
Fabien requested changes to this revision.Aug 7 2019, 07:37

The fix for guiutil.h is missing.
The fix for interpreter.cpp is missing (moved to sigencoding.cpp, IsValidDERSignatureEncoding).
The fix for util.h is missing (moved to logging.h).
The fix for is missing.

You can keep the change to workaround in, just don't add it to the dictionary.

161 ↗(On Diff #10636)

While you're at it you can remove the extra spaces (or improve the layout).
This is not really out-of-scope as the original PR has a fix for this comment (that doesn't apply to us).

This revision now requires changes to proceed.Aug 7 2019, 07:37
nakihito requested review of this revision.Aug 7 2019, 23:26
nakihito added inline comments.
158 ↗(On Diff #10656)

This workaround is being used as a noun as pointed out here: and is therefore okay.

493 ↗(On Diff #10656)

This workaround is not being used as a noun. Rather, it is being used to describe the method by which something is being done and as such should be split into two different words.

Fabien requested changes to this revision.Aug 8 2019, 07:16
Fabien added inline comments.
513 ↗(On Diff #10656)

This one is still missing

161 ↗(On Diff #10656)

That's better, but you can remove one more. A single space is enough.

This revision now requires changes to proceed.Aug 8 2019, 07:16

Fixed formatting and another typo.

deadalnix requested changes to this revision.Sep 12 2019, 10:54
deadalnix added inline comments.
12 ↗(On Diff #10681)


This revision now requires changes to proceed.Sep 12 2019, 10:54
This revision is now accepted and ready to land.Sep 21 2019, 12:05