Page MenuHomePhabricator

Factor out getId() from Misbehaving(..) calls
ClosedPublic

Authored by awemany on Jul 27 2017, 09:16.

Details

Summary

Factor out repeated getId() calls from Misbehaving(..) lines.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D380
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 596
Build 596: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jul 27 2017, 10:05

What version of clang format are you using ? Maybe we should consider upgrading the one most people use because ti looks like it formats differently.

src/net_processing.cpp
808 ↗(On Diff #955)

static .

This revision now requires changes to proceed.Jul 27 2017, 10:05
awemany edited edge metadata.

Formatting with clang-format-3.8 again.

src/net_processing.cpp
780

Making that one static should break the build.

awemany added inline comments.
src/net_processing.cpp
808 ↗(On Diff #955)

fixed

This revision is now accepted and ready to land.Jul 27 2017, 11:03

Really good you did this. I hate the way that call looked before. Good job.

This revision was automatically updated to reflect the committed changes.
awemany marked an inline comment as done.