Page MenuHomePhabricator
Differential D4255

bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet
ClosedPublic
Actions

Authored by nakihito on Oct 15 2019, 02:27.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in…
rABC40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in…
Summary

Partial backport of Core PR13111
https://github.com/bitcoin/bitcoin/pull/13111/commits/0b82bac76d0f842bd2294a290388536951fbc576 (only the remaining change to wallet/db.cpp)
https://github.com/bitcoin/bitcoin/pull/13111/commits/fe65bdec237776dbe094339509dfd2e63329a832

Depends on D4254

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13111-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7779
Build 13597: Bitcoin ABC Buildbot (legacy)
Build 13596: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 15 2019, 02:27
Owners added a reviewer: Restricted Owners Package.Oct 15 2019, 02:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 02:27
nakihito planned changes to this revision.Oct 15 2019, 02:27
teamcity added a comment.Oct 15 2019, 02:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 15 2019, 02:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7772: Diff 13557.Oct 15 2019, 02:39
nakihito requested review of this revision.Oct 15 2019, 02:44
nakihito added inline comments.
src/wallet/db.cpp
773 ↗(On Diff #13557)

Review note: the change to this part of the code is just adding braces.

jasonbcox requested changes to this revision.Oct 15 2019, 15:38
jasonbcox added inline comments.
src/wallet/db.cpp
872 ↗(On Diff #13557)

Brackets

This revision now requires changes to proceed.Oct 15 2019, 15:38
nakihito updated this revision to Diff 13564.Oct 15 2019, 16:33

Added braces.

teamcity added a comment.Oct 15 2019, 16:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 15 2019, 16:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7779: Diff 13564.Oct 15 2019, 16:44
jasonbcox accepted this revision.Oct 16 2019, 20:27
This revision is now accepted and ready to land.Oct 16 2019, 20:27
Closed by commit rABC40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by nakihito). · Explain WhyOct 19 2019, 02:36
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in….
nakihito mentioned this in D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.Oct 23 2019, 01:40
Nico Guiton <nico@bitframe.org> mentioned this in rABC8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.Oct 24 2019, 07:38
nakihito added a commit: rSTAGING40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in….Apr 7 2020, 21:27
nakihito mentioned this in rSTAGING8915b2f748fa: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.

Revision Contents
Changeset List

PathSize
src/
qt/
1 line
wallet/
4 lines

Diff 13564

View Options

src/qt/walletframe.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...