Page MenuHomePhabricator

bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet
ClosedPublic

Authored by nakihito on Oct 15 2019, 02:27.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13111-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7779
Build 13597: Bitcoin ABC Buildbot (legacy)
Build 13596: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 15 2019, 02:27
nakihito added inline comments.
src/wallet/db.cpp
773 ↗(On Diff #13557)

Review note: the change to this part of the code is just adding braces.

jasonbcox requested changes to this revision.Oct 15 2019, 15:38
jasonbcox added inline comments.
src/wallet/db.cpp
872 ↗(On Diff #13557)

Brackets

This revision now requires changes to proceed.Oct 15 2019, 15:38
This revision is now accepted and ready to land.Oct 16 2019, 20:27