Use FRC::randbytes instead of reading >32 bytes from RNG
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:40.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGdb22ce1e682d: Use FRC::randbytes instead of reading >32 bytes from RNG
rABCdb22ce1e682d: Use FRC::randbytes instead of reading >32 bytes from RNG

Summary

There was only one place in the codebase where we're directly reading >32 bytes from
the RNG. One possibility would be to make the built-in RNG support large reads, but
using FastRandomContext lets us reuse code better.

There is no change in behavior here, because the FastRandomContext constructor
uses GetRandBytes internally.

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/6a57ca91da23c6a5d91399ffc7fc09a99b6d4c76

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14955-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7997
Build 13993: Bitcoin ABC Buildbot (legacy)
Build 13992: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 5 2019, 22:40

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4389: Don't log RandAddSeedPerfmon details.Nov 5 2019, 22:42

jasonbcox accepted this revision.Nov 5 2019, 22:50

This revision is now accepted and ready to land.Nov 5 2019, 22:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7997: Diff 13937.Nov 5 2019, 22:51

Closed by commit rABCdb22ce1e682d: Use FRC::randbytes instead of reading >32 bytes from RNG (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 15:54

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCdb22ce1e682d: Use FRC::randbytes instead of reading >32 bytes from RNG.

nakihito added a commit: rSTAGINGdb22ce1e682d: Use FRC::randbytes instead of reading >32 bytes from RNG.Apr 7 2020, 21:37

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

paymentservertests.cpp

7 lines

Diff 13937

View Options

src/qt/test/paymentservertests.cpp

Use FRC::randbytes instead of reading >32 bytes from RNGClosedPublicActions