Page MenuHomePhabricator
Differential D4822

[Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object
ClosedPublic
Actions

Authored by nakihito on Jan 2 2020, 21:48.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput…
rABC8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput…
Summary

Partial backport of Core PR13669
https://github.com/bitcoin/bitcoin/pull/13669/commits/44bbceeef1b76526b73cbdd3ff785c4d5b2c74f1

Depends on D4821

Test Plan
test_runner.py feature_block

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13669-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8714
Build 15413: Default Diff Build & Tests
Build 15412: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 2 2020, 21:48
Owners added a reviewer: Restricted Owners Package.Jan 2 2020, 21:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 2 2020, 21:48
nakihito planned changes to this revision.Jan 2 2020, 21:48
teamcity added a comment.Jan 2 2020, 21:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 2 2020, 22:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8714: Diff 15119.Jan 2 2020, 22:02
nakihito edited the summary of this revision. (Show Details)Jan 3 2020, 01:04
nakihito added a parent revision: D4821: [Tests] Cleanup extra instances of create_transaction.
nakihito requested review of this revision.Jan 3 2020, 20:18
deadalnix accepted this revision.Jan 4 2020, 06:36
This revision is now accepted and ready to land.Jan 4 2020, 06:36
Closed by commit rABC8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput… (authored by Conor Scott <conor.r.scott.88@gmail.com>, committed by nakihito). · Explain WhyJan 6 2020, 17:45
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput….
nakihito added a commit: rSTAGING8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput….Apr 7 2020, 22:17

Revision Contents
Changeset List

PathSize
test/
functional/
94 lines

Diff 15119

View Options

test/functional/feature_block.py

Loading...