Differential D5868

[backport#15288] Remove use of uiInterface.LoadWallet in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 28 2020, 06:16.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc7342637bf75: [backport#15288] Remove use of uiInterface.LoadWallet in wallet code
rABCc7342637bf75: [backport#15288] Remove use of uiInterface.LoadWallet in wallet code

Summary

This also changes the uiInterface.LoadWallet signal argument type from
shared_ptr<CWallet> to unique_ptr<interfaces::Wallet> because CWallet is an
internal wallet class that shouldn't be used in non-wallet code (and also can't
be passed across process boundaries).

This commit does not change behavior.

1106a6fde4bfde31a16de45e4cc84ed5da05c5a4 (Russell Yanofksi)

Depends on D5867

This is a partial backport of Core PR15288

Test Plan

cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15288

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10445
Build 18710: Default Diff Build & Tests
Build 18709: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 28 2020, 06:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 06:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10445: Diff 19191.Apr 28 2020, 06:33

majcosta added a child revision: D5869: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.Apr 28 2020, 07:47

You need to point to the part of the PR it refers to.

This revision now requires changes to proceed.Apr 28 2020, 13:49

fixed missing commit hash

majcosta requested review of this revision.Apr 28 2020, 14:16

deadalnix accepted this revision.Apr 28 2020, 15:59

This revision is now accepted and ready to land.Apr 28 2020, 15:59

Closed by commit rABCc7342637bf75: [backport#15288] Remove use of uiInterface.LoadWallet in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 28 2020, 18:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCc7342637bf75: [backport#15288] Remove use of uiInterface.LoadWallet in wallet code.

majcosta added a commit: rSTAGINGc7342637bf75: [backport#15288] Remove use of uiInterface.LoadWallet in wallet code.May 5 2020, 19:11

Revision Contents
Changeset List

Path

Size

src/

2 lines

Makefile.bench.include

2 lines

interfaces/

5 lines

4 lines

4 lines

8 lines

ui_interface.cpp

3 lines

wallet/

3 lines

Diff 19191

src/Makefile.am

Loading...

src/Makefile.bench.include

Loading...

src/interfaces/chain.h

Loading...

src/interfaces/chain.cpp

Loading...

src/interfaces/node.cpp

Loading...

src/ui_interface.h

Loading...

src/ui_interface.cpp

Loading...

src/wallet/wallet.cpp

Loading...