Page MenuHomePhabricator

[backport#15288] Remove use of uiInterface.LoadWallet in wallet code
ClosedPublic

Authored by majcosta on Apr 28 2020, 06:16.

Details

Summary

This also changes the uiInterface.LoadWallet signal argument type from
shared_ptr<CWallet> to unique_ptr<interfaces::Wallet> because CWallet is an
internal wallet class that shouldn't be used in non-wallet code (and also can't
be passed across process boundaries).

This commit does not change behavior.

1106a6fde4bfde31a16de45e4cc84ed5da05c5a4 (Russell Yanofksi)


Depends on D5867

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10445
Build 18710: Default Diff Build & Tests
Build 18709: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 28 2020, 13:49
deadalnix added a subscriber: deadalnix.

You need to point to the part of the PR it refers to.

This revision now requires changes to proceed.Apr 28 2020, 13:49

fixed missing commit hash

This revision is now accepted and ready to land.Apr 28 2020, 15:59