Page MenuHomePhabricator
Differential D5869

[backport#15288] Remove use of IsInitialBlockDownload in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 28 2020, 07:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code
rABC98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code
Summary

a1df1b48a80bf122efa73677ff72577ec0103a3b This commit does not change behavior. (Russell Yanofksi)

Depends on D5868, completes T602

This is a backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10446
Build 18712: Default Diff Build & Tests
Build 18711: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 28 2020, 07:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 07:47
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 07:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 28 2020, 07:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta edited the summary of this revision. (Show Details)Apr 28 2020, 07:54
teamcity added a comment.Apr 28 2020, 07:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10446: Diff 19193.Apr 28 2020, 07:58
majcosta added a child revision: D5870: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288.Apr 28 2020, 08:43
deadalnix accepted this revision.Apr 28 2020, 13:51
This revision is now accepted and ready to land.Apr 28 2020, 13:51
Closed by commit rABC98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 28 2020, 19:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.
majcosta mentioned this in T602: Backport Core PR 15288: Remove wallet -> node global function calls.Apr 28 2020, 19:05
majcosta added a commit: rSTAGING98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.May 5 2020, 19:11

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
3 lines
wallet/
2 lines

Diff 19193

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...