Page MenuHomePhabricator

[backport#10973] Remove remaining wallet accesses to node globals
ClosedPublic

Authored by majcosta on May 3 2020, 09:14.

Details

Summary

https://github.com/bitcoin/bitcoin/pull/10973/commits/d358466de15ef29c1d2bccb9aebab360d574d1d0 Remove remaining wallet accesses to node globals (Russell Yanofsky)


Depends on D5927, completes T601

This is a partial backport of Core PR10973

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10973_2_squashed
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10563
Build 18937: Default Diff Build & Tests
Build 18936: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested review of this revision.May 3 2020, 09:24
Fabien requested changes to this revision.May 3 2020, 10:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/chain.h
203 ↗(On Diff #19385)

no -incrementalrelayfee here

This revision now requires changes to proceed.May 3 2020, 10:12

removed irrelevant comment

This revision is now accepted and ready to land.May 3 2020, 11:55