Differential D8100

Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 21:49.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC27fe47e7afc9: Use CWallet::SignTransaction in CreateTransaction and…

Summary

Instead of duplicating signing code, just use the function we already
have.

Backport of Core PR18115 part [4/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/a4af324d15c1ee43c2abd11a304ae18c7ee82eb0

Depends on D8098

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 24 2020, 21:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 21:49

deadalnix requested review of this revision.Oct 24 2020, 21:49

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 21:49

Harbormaster completed remote builds in B13652: Diff 25056.Oct 24 2020, 22:01

majcosta accepted this revision.Oct 24 2020, 23:42

This revision is now accepted and ready to land.Oct 24 2020, 23:42

Closed by commit rABC27fe47e7afc9: Use CWallet::SignTransaction in CreateTransaction and… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 24 2020, 23:55

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC27fe47e7afc9: Use CWallet::SignTransaction in CreateTransaction and….

deadalnix added a child revision: D8114: Replace GetSigningProvider with GetSolvingProvider.Oct 25 2020, 15:29

PiRK mentioned this in D10085: wallet: Don't override signing errors.Sep 9 2021, 12:54

PiRK mentioned this in rABCf58d3ab83703: wallet: Don't override signing errors.Sep 10 2021, 10:10

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

25 lines

scriptpubkeyman.h

3 lines

wallet.cpp

35 lines

Diff 25063

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/scriptpubkeyman.h

View Options

Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwalletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25063

src/wallet/rpcwallet.cpp

src/wallet/scriptpubkeyman.h

src/wallet/wallet.cpp

Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet
ClosedPublic
Actions

Revision Contents
Changeset List