Details

Reviewers

alcipir
deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rABC937e3797392e: [cashtab] use npm ci instead of install on CI

Summary

npm ci will clean node_modules directory and install dependencies from
package-lock.json file, ensuring builds are deterministic.

this should also be the workflow for building the app locally to
develop as to avoid spurious repo changes when the package.json file has
not been altered

Test Plan

run on CI and check logs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

npm_ci

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14666
Build 29291: Build Diff
Build 29290: arc lint + arc unit

Event Timeline

majcosta created this revision.Jan 8 2021, 12:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2021, 12:11

majcosta requested review of this revision.Jan 8 2021, 12:11

Harbormaster completed remote builds in B14662: Diff 26786.Jan 8 2021, 12:11

@bot cashtab-tests

teamcity awarded a token.Jan 8 2021, 12:14

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

adding nodejs

Harbormaster completed remote builds in B14663: Diff 26787.Jan 8 2021, 12:29

@bot cashtab-tests

teamcity updated a token.Jan 8 2021, 12:31

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

investigating bustedness

Can you add these instructions to the README? (instead of npm install, npm ci)

In D8849#203179, @alcipir wrote:

Can you add these instructions to the README? (instead of npm install, npm ci)

I'll limit this to CI only for now since I know it builds there with no issues.

fixed backports installation erroring out and fixed the issue with npm breaking when trying to talk to github via ssh

Harbormaster completed remote builds in B14666: Diff 26793.Jan 8 2021, 15:14

@bot cashtab-tests

teamcity updated a token.Jan 8 2021, 15:16

deadalnix accepted this revision.Jan 8 2021, 15:34

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook gets SLP and BCH balances and utxos ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 4
+ Received  + 4

@@ -21,11 +21,11 @@
        "satoshis": 546,
        "tokenDocumentHash": "",
        "tokenDocumentUrl": "mint.bitcoin.com",
        "tokenId": "009ff65ef50632111a9661f67d80025481ebc80ced239d32a92705b04d5df8cc",
        "tokenName": "TT",
-       "tokenQty": 7,
+       "tokenQty": "7",
        "tokenTicker": "TTT",
        "tokenType": 1,
        "transactionType": "send",
        "tx_hash": "bb055d815e795d7a4fe41fd67288d71886678e7d1e5ba9ddd7f6daffa5f70ceb",
        "tx_pos": 2,
@@ -42,11 +42,11 @@
        "satoshis": 546,
        "tokenDocumentHash": "",
        "tokenDocumentUrl": "mint.bitcoin.com",
        "tokenId": "2aef6e63edfded1a299e78b529286deea2a6dd5299b6911778c25632d78a9479",
        "tokenName": "pitico",
-       "tokenQty": 99.35,
+       "tokenQty": "99.35",
        "tokenTicker": "PTC",
        "tokenType": 1,
        "transactionType": "send",
        "tx_hash": "88b7dac07cb30566a6264f330bedda690c8dff151c2307692c79e13dc59ca2ba",
        "tx_pos": 2,
@@ -68,11 +68,11 @@
          "satoshis": 546,
          "tokenDocumentHash": "",
          "tokenDocumentUrl": "mint.bitcoin.com",
          "tokenId": "009ff65ef50632111a9661f67d80025481ebc80ced239d32a92705b04d5df8cc",
          "tokenName": "TT",
-         "tokenQty": 7,
+         "tokenQty": "7",
          "tokenTicker": "TTT",
          "tokenType": 1,
          "transactionType": "send",
          "tx_hash": "bb055d815e795d7a4fe41fd67288d71886678e7d1e5ba9ddd7f6daffa5f70ceb",
          "tx_pos": 2,
@@ -94,11 +94,11 @@
          "satoshis": 546,
          "tokenDocumentHash": "",
          "tokenDocumentUrl": "mint.bitcoin.com",
          "tokenId": "2aef6e63edfded1a299e78b529286deea2a6dd5299b6911778c25632d78a9479",
          "tokenName": "pitico",
-         "tokenQty": 99.35,
+         "tokenQty": "99.35",
          "tokenTicker": "PTC",
          "tokenType": 1,
          "transactionType": "send",
          "tx_hash": "88b7dac07cb30566a6264f330bedda690c8dff151c2307692c79e13dc59ca2ba",
          "tx_pos": 2,
    at Object.it (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:75:24)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook gets SLP and BCH balances and utxos