Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
ClosedPublic
Actions

Authored by deadalnix on Jul 9 2019, 19:49.

Details

Reviewers

Fabien
jasonbcox
markblundeberg
nakihito

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

Summary

5a9b508 [trivial] Add end of namespace comments (practicalswift)

Tree-SHA512: 92b0fcae4d1d3f4da9e97569ae84ef2d6e09625a5815cd0e5f0eb6dd2ecba9852fa85c184c5ae9de5117050330ce995e9867b451fa8cd5512169025990541a2b

Backport of Core PR9544
https://github.com/bitcoin/bitcoin/pull/9544/files

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D3619

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6858
Build 11763: Bitcoin ABC Buildbot (legacy)
Build 11762: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 9 2019, 19:49

Owners added a reviewer: Restricted Owners Package.Jul 9 2019, 19:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 19:49

nakihito planned changes to this revision.Jul 9 2019, 19:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6775: Diff 10157.Jul 9 2019, 19:57

base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.

There is a tool that can do this automatically and exaustively. Use it.

This revision now requires changes to proceed.Jul 10 2019, 23:56

deadalnix commandeered this revision.Jul 14 2019, 17:49

deadalnix edited reviewers, added: nakihito; removed: deadalnix.

Update cland-format to enforce the new style

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6858: Diff 10288.Jul 14 2019, 18:00

nakihito accepted this revision.Jul 15 2019, 22:39

jasonbcox accepted this revision.Jul 16 2019, 03:01

This revision is now accepted and ready to land.Jul 16 2019, 03:01

Closed by commit rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyJul 16 2019, 12:59

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

deadalnix added a commit: rSTAGINGd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..Sep 19 2019, 01:17

Revision Contents
Changeset List

Path

Size

doc/

developer-notes.md

17 lines

src/

.clang-format

2 lines

addrdb.cpp

2 lines

avalanche.h

2 lines

bench/

bench.h

2 lines

checkblock.cpp

2 lines

crypto/

4 lines

6 lines

2 lines

4 lines

2 lines

2 lines

2 lines

qt/

bitcoingui.h

2 lines

clientmodel.h

2 lines

splashscreen.h

2 lines

test/

paymentservertests.cpp

2 lines

2 lines

2 lines

2 lines

2 lines

walletmodeltransaction.h

2 lines

Diff 10288

View Options

doc/developer-notes.md

View Options

src/.clang-format

View Options

src/addrdb.cpp

View Options

src/avalanche.h

View Options

src/bench/bench.h

View Options

src/bench/checkblock.cpp

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_shani.cpp

View Options

src/crypto/sha256_sse4.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/fs.h

View Options

src/fs.cpp

View Options

src/net_processing.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/clientmodel.h

View Options

src/qt/splashscreen.h

View Options

src/qt/test/paymentservertests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiondesc.h

View Options

src/qt/transactionrecord.h

View Options

src/qt/walletmodel.h

View Options

src/qt/walletmodeltransaction.h

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10288

doc/developer-notes.md

src/.clang-format

src/addrdb.cpp

src/avalanche.h

src/bench/bench.h

src/bench/checkblock.cpp

src/crypto/sha256_avx2.cpp

src/crypto/sha256_shani.cpp

src/crypto/sha256_sse4.cpp

src/crypto/sha256_sse41.cpp

src/fs.h

src/fs.cpp

src/net_processing.cpp

src/qt/bitcoingui.h

src/qt/clientmodel.h

src/qt/splashscreen.h

src/qt/test/paymentservertests.cpp

src/qt/test/wallettests.cpp

src/qt/transactiondesc.h

src/qt/transactionrecord.h

src/qt/walletmodel.h

src/qt/walletmodeltransaction.h

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
ClosedPublic
Actions

Revision Contents
Changeset List