Page MenuHomePhabricator
Differential D4029

Merge #13012: [doc] Add comments for chainparams.h, validation.cpp
ClosedPublic
Actions

Authored by nakihito on Sep 10 2019, 19:17.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING51744dde9d2b: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp
rABC51744dde9d2b: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp
Summary

18326ae [doc] Add comments for chainparams.h, validation.cpp (James O'Beirne)

Pull request description:

Added a few comments during a leisurely read through some of the validation code. If this kind of thing seems useful, I can add similar documentation for most of the `CChainState` interface.

Tree-SHA512: a4d9db60383a8ff02e74ac326ed88902eec1ee441e8cd4e1845bcf257072673c15974225288cebf0a633e76a3410f99e2206616b4694725a2a5b0d19c78327d6

Backport of Core PR13012
https://github.com/bitcoin/bitcoin/pull/13012/

Depends on D4045

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13012
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7404
Build 12851: Bitcoin ABC Buildbot (legacy)
Build 12850: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 10 2019, 19:17
Owners added a reviewer: Restricted Owners Package.Sep 10 2019, 19:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2019, 19:17
teamcity added a comment.Sep 10 2019, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito mentioned this in D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.Sep 10 2019, 19:20
nakihito added a child revision: D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.Sep 10 2019, 19:21
teamcity added a comment.Sep 10 2019, 19:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7377: Diff 11181.Sep 10 2019, 19:27
jasonbcox requested changes to this revision.Sep 10 2019, 19:52
jasonbcox added inline comments.
src/validation.cpp
2854 ↗(On Diff #11181)

This top half of the comment is clearly not part of the original PR. Please add reviewer notes as to why this is the case. Otherwise reviewers are forced to assume that a dependency/backport was missed.

This revision now requires changes to proceed.Sep 10 2019, 19:52
nakihito added inline comments.Sep 10 2019, 20:18
src/validation.cpp
2854 ↗(On Diff #11181)

This was removed here: D1182. There's no real explanation why it was removed though?

nakihito requested review of this revision.Sep 10 2019, 21:26
deadalnix requested changes to this revision.Sep 11 2019, 04:51
deadalnix added inline comments.
src/validation.cpp
2854 ↗(On Diff #11181)

It was moved in the header. Regardless of what you do, do something consistent.

This revision now requires changes to proceed.Sep 11 2019, 04:51
nakihito edited the summary of this revision. (Show Details)Sep 11 2019, 20:42
nakihito added a parent revision: D4045: Revert change to ActivateBestChain() comments made in D1182.
nakihito updated this revision to Diff 11225.Sep 11 2019, 20:56

Rebased off D4045.

nakihito planned changes to this revision.Sep 11 2019, 20:56
teamcity added a comment.Sep 11 2019, 20:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7404: Diff 11225.Sep 11 2019, 21:11
teamcity added a comment.Sep 11 2019, 21:11

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito updated this revision to Diff 13021.Sep 19 2019, 20:41

Rebased.

teamcity added a comment.Sep 19 2019, 20:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 20:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 20:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 19 2019, 21:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7517: Diff 13021.Sep 19 2019, 21:08
jasonbcox accepted this revision.Sep 20 2019, 22:44
deadalnix accepted this revision.Sep 21 2019, 11:59
This revision is now accepted and ready to land.Sep 21 2019, 11:59
Closed by commit rABC51744dde9d2b: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 23 2019, 17:03
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC51744dde9d2b: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING51744dde9d2b: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.Sep 27 2019, 22:47

Revision Contents
Changeset List

PathSize
src/
6 lines
18 lines

Diff 11225

View Options

src/chainparams.h

Loading...
View Options

src/validation.cpp

Loading...