Page MenuHomePhabricator
Differential D5943

[backport#10973] Remove remaining wallet accesses to node globals
ClosedPublic
Actions

Authored by majcosta on May 3 2020, 09:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5cf1cf93d7d2: [backport#10973] Remove remaining wallet accesses to node globals
rABC5cf1cf93d7d2: [backport#10973] Remove remaining wallet accesses to node globals
Summary

https://github.com/bitcoin/bitcoin/pull/10973/commits/d358466de15ef29c1d2bccb9aebab360d574d1d0 Remove remaining wallet accesses to node globals (Russell Yanofsky)

Depends on D5927, completes T601

This is a partial backport of Core PR10973

Test Plan
cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10973_2_squashed
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10563
Build 18937: Default Diff Build & Tests
Build 18936: arc lint + arc unit

Event Timeline

majcosta created this revision.May 3 2020, 09:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2020, 09:14
teamcity edited the summary of this revision. (Show Details)May 3 2020, 09:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 3 2020, 09:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 3 2020, 09:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10562: Diff 19385.May 3 2020, 09:24
majcosta requested review of this revision.May 3 2020, 09:24
teamcity added a comment.May 3 2020, 10:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 3 2020, 10:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Fabien requested changes to this revision.May 3 2020, 10:12
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/chain.h
203 ↗(On Diff #19385)

no -incrementalrelayfee here

This revision now requires changes to proceed.May 3 2020, 10:12
majcosta updated this revision to Diff 19386.May 3 2020, 11:19

removed irrelevant comment

teamcity added a comment.May 3 2020, 11:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 3 2020, 11:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10563: Diff 19386.May 3 2020, 11:29
Fabien accepted this revision.May 3 2020, 11:55
This revision is now accepted and ready to land.May 3 2020, 11:55
Closed by commit rABC5cf1cf93d7d2: [backport#10973] Remove remaining wallet accesses to node globals (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 3 2020, 12:52
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5cf1cf93d7d2: [backport#10973] Remove remaining wallet accesses to node globals.
majcosta added a commit: rSTAGING5cf1cf93d7d2: [backport#10973] Remove remaining wallet accesses to node globals.May 5 2020, 19:18
majcosta mentioned this in D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.Jun 30 2020, 22:56
majcosta mentioned this in rABC1f1482f5483f: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.Jun 30 2020, 23:25
majcosta mentioned this in T601: Backport Core PR 10973: Refactor: separate wallet from node.Aug 5 2021, 00:12

Revision Contents
Changeset List

PathSize
src/
interfaces/
16 lines
9 lines
7 lines
wallet/
7 lines
2 lines
14 lines
4 lines
2 lines
30 lines

Diff 19386

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...