Differential D8793

p2p: clean up Misbehaving()
ClosedPublic
Actions

Authored by Fabien on Jan 5 2021, 14:48.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC772ce2616568: p2p: clean up Misbehaving()

Summary

This PR makes a few minor clean-ups to Misbehaving() in preparation to
move it out of the cs_main lock.

There are very minor logging changes but otherwise no functional
changes.

Backport of core PR19583.

Depends on D8792.

Some of our Misbehaving messages are updated to match core messages.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19583

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14588
Build 29137: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29136: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 5 2021, 14:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2021, 14:48

Fabien requested review of this revision.Jan 5 2021, 14:48

teamcity edited the summary of this revision. (Show Details)Jan 5 2021, 14:48

Harbormaster completed remote builds in B14574: Diff 26637.Jan 5 2021, 14:58

Fabien added a child revision: D8794: [p2p] Add Peer struct for per-peer data in net processing.Jan 5 2021, 16:10

majcosta requested changes to this revision.Jan 5 2021, 20:50

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/net_processing.cpp
3492–3493 ↗	(On Diff #26637)	I think this is misplaced with the change to the call to Misbehaving in line 3652

This revision now requires changes to proceed.Jan 5 2021, 20:50

Fix misplaced misbahving message

Harbormaster completed remote builds in B14588: Diff 26656.Jan 6 2021, 09:03

majcosta accepted this revision.Jan 6 2021, 09:20

This revision is now accepted and ready to land.Jan 6 2021, 09:20

Closed by commit rABC772ce2616568: p2p: clean up Misbehaving() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 6 2021, 11:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC772ce2616568: p2p: clean up Misbehaving().

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

3 lines

net_processing.cpp

61 lines

Diff 26656

src/net_processing.h

Loading...

src/net_processing.cpp

Loading...