Paths

Table of Contentst

Differential D10095

wallet: GetWalletTx requires cs_wallet lock
ClosedPublic
Actions

Authored by PiRK on Sep 13 2021, 14:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9712e1445364: wallet: GetWalletTx requires cs_wallet lock

Summary

PR description:

This change removes some unlock/lock and lock/lock cases regarding GetWalletTx and IsMine overloads.

This is a backport of core#19289 [1/3]
https://github.com/bitcoin/bitcoin/pull/19289/commits/a13cafc6c6998baedf3c5766259c21fcd763b99e

Test Plan

With TSAN:
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16618
Build 33091: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 33090: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 13 2021, 14:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 14:33

PiRK requested review of this revision.Sep 13 2021, 14:33

teamcity edited the summary of this revision. (Show Details)Sep 13 2021, 14:33

Harbormaster completed remote builds in B16618: Diff 29905.Sep 13 2021, 14:46

Fabien accepted this revision.Sep 13 2021, 18:38

This revision is now accepted and ready to land.Sep 13 2021, 18:38

PiRK added a child revision: D10096: wallet: IsMine overloads require cs_wallet lock.Sep 14 2021, 06:21

Closed by commit rABC9712e1445364: wallet: GetWalletTx requires cs_wallet lock (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhySep 14 2021, 06:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9712e1445364: wallet: GetWalletTx requires cs_wallet lock.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

3 lines

wallet.cpp

3 lines

Diff 29905

View Options

src/wallet/wallet.h