Differential D12328

[move-only] Match ordering of CAddrMan declarations and definitions
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:55.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCaa2641ec9a81: [move-only] Match ordering of CAddrMan declarations and definitions

Summary

Also move `Check` and `ForceCheckAddrman` to be after the `FunctionName_` functions.

Also move Clear() at the end together with MakeDeterministic(), as both these methods don't exist in core's codebase.

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/f2e5f38f09ee40933f752680fe7d75ee8e529fae

Depends on D12327.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22950_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20635
Build 40934: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40933: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 20 2022, 12:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:55

Fabien requested review of this revision.Oct 20 2022, 12:55

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:55

Fabien added a child revision: D12329: [addrman] Introduce CAddrMan::Impl to encapsulate addrman implementation..Oct 20 2022, 12:55

Harbormaster completed remote builds in B20635: Diff 35881.Oct 20 2022, 13:14

PiRK accepted this revision.Oct 20 2022, 13:53

This revision is now accepted and ready to land.Oct 20 2022, 13:53

Closed by commit rABCaa2641ec9a81: [move-only] Match ordering of CAddrMan declarations and definitions (authored by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaa2641ec9a81: [move-only] Match ordering of CAddrMan declarations and definitions.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

52 lines

addrman.cpp

314 lines

Diff 35881

View Options

src/addrman.h