Paths

Table of Contentst

Differential D12337

scripted-diff: Rename CAddrMan to AddrMan
ClosedPublic
Actions

Authored by Fabien on Oct 20 2022, 12:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC10ab03ff9274: scripted-diff: Rename CAddrMan to AddrMan

Summary

Partial backport of core#22950:
https://github.com/bitcoin/bitcoin/pull/22950/commits/dd8f7f250095e58bbf4cd4effb481b52143bd1ed

Depends on D12336.

There is no change in behavior.

Test Plan

ninja all check-all
ninja bitcoin-fuzzers
ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22950_p11

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20644
Build 40952: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 40951: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 20 2022, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2022, 12:58

Fabien requested review of this revision.Oct 20 2022, 12:58

teamcity edited the summary of this revision. (Show Details)Oct 20 2022, 12:59

Fabien added a child revision: D12338: scripted-diff: Rename CAddrInfo to AddrInfo.Oct 20 2022, 12:59

Harbormaster completed remote builds in B20644: Diff 35890.Oct 20 2022, 14:08

PiRK accepted this revision.Oct 20 2022, 15:29

This revision is now accepted and ready to land.Oct 20 2022, 15:29

You should add bench-bitcoin to test plan. Not blocking on this, as the change is trivial.

Fabien edited the test plan for this revision. (Show Details)Oct 20 2022, 18:25

Closed by commit rABC10ab03ff9274: scripted-diff: Rename CAddrMan to AddrMan (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyOct 21 2022, 08:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC10ab03ff9274: scripted-diff: Rename CAddrMan to AddrMan.

Revision Contents
Changeset List

Path

Size

src/

8 lines

10 lines

10 lines

61 lines

4 lines

bench/

26 lines

4 lines

2 lines

4 lines

13 lines

2 lines

2 lines

node/

context.h

4 lines

test/

addrman_tests.cpp

80 lines

fuzz/

deserialize.cpp

4 lines

util/

setup_common.cpp

2 lines

test/

functional/

feature_addrman.py

4 lines

Diff 35890

View Options

src/addrdb.h

View Options

src/addrdb.cpp

View Options

src/addrman.h

View Options

src/addrman.cpp

View Options

src/addrman_impl.h

View Options

src/bench/addrman.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/netaddress.h

View Options

src/netaddress.cpp

View Options

src/node/context.h

View Options

src/test/addrman_tests.cpp

View Options

src/test/fuzz/deserialize.cpp

View Options

src/test/util/setup_common.cpp

View Options

test/functional/feature_addrman.py

scripted-diff: Rename CAddrMan to AddrManClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35890

src/addrdb.h

src/addrdb.cpp

src/addrman.h

src/addrman.cpp

src/addrman_impl.h

src/bench/addrman.cpp

src/net.h

src/net.cpp

src/net_processing.h

src/net_processing.cpp

src/netaddress.h

src/netaddress.cpp

src/node/context.h

src/test/addrman_tests.cpp

src/test/fuzz/deserialize.cpp

src/test/util/setup_common.cpp

test/functional/feature_addrman.py

scripted-diff: Rename CAddrMan to AddrMan
ClosedPublic
Actions

Revision Contents
Changeset List