Page MenuHomePhabricator
Differential D1566

Add test for CheckPubKeyEncoding
ClosedPublic
Actions

Authored by deadalnix on Jul 15 2018, 00:59.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING81ee26544b1b: Add test for CheckPubKeyEncoding
rABC81ee26544b1b: Add test for CheckPubKeyEncoding
Summary

As per title. More test is better.

Depends on D1565

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigencodingtest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2872
Build 3848: Bitcoin ABC Buildbot (legacy)
Build 3847: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 15 2018, 00:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2018, 00:59
deadalnix edited the summary of this revision. (Show Details)Jul 15 2018, 01:00
deadalnix added a parent revision: D1565: Move function checking encoding of public key and signature out of interpreter.{h/cpp}.
teamcity added a subscriber: teamcity.Jul 15 2018, 01:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 15 2018, 01:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2872: Diff 4306.Jul 15 2018, 01:39
deadalnix added a child revision: D1568: Check error code return by CheckPubKeyEncoding in tests.Jul 15 2018, 13:52
deadalnix added a child revision: D1567: Add test cases for CheckSignatureEncoding.Jul 15 2018, 13:52
jasonbcox requested changes to this revision.Jul 16 2018, 19:11
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/sigencoding_tests.cpp
37

I see invalid checks for 0x00 and 0x05 and valid checks for 0x02, 0x03, 0x04. Please add a test for 0x01, as it's not covered in this test.

This revision now requires changes to proceed.Jul 16 2018, 19:11
deadalnix updated this revision to Diff 4328.Jul 16 2018, 22:06

Add test case starting with 0x01

teamcity added a comment.Jul 16 2018, 22:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 16 2018, 22:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2887: Diff 4328.Jul 16 2018, 22:46
jasonbcox accepted this revision.Jul 17 2018, 15:04
This revision is now accepted and ready to land.Jul 17 2018, 15:04
Closed by commit rABC81ee26544b1b: Add test for CheckPubKeyEncoding (authored by deadalnix). · Explain WhyJul 17 2018, 16:00
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4306

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/sigencoding_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...