Differential D16285

Fix issues when calling std::move(const&)
ClosedPublic
Actions

Authored by Fabien on Jun 5 2024, 12:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC396e95c443fb: Fix issues when calling std::move(const&)

Summary

Passing a symbol to std::move that is marked const is a no-op, which can be fixed in two ways:
 - Remove the const, or
 - Remove the std::move

Backport of core#25872.

Depends on D16288.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25872

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29230
Build 57996: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 57995: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 5 2024, 12:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2024, 12:24

Fabien requested review of this revision.Jun 5 2024, 12:24

teamcity edited the summary of this revision. (Show Details)Jun 5 2024, 12:24

Harbormaster completed remote builds in B29225: Diff 48116.Jun 5 2024, 12:28

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[384/568] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[385/568] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[386/568] Linking C executable src/secp256k1/internal-bench
[387/568] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[388/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[389/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[390/568] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[391/568] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[392/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[393/568] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[394/568] Linking CXX executable src/bitcoin-cli
[395/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[396/568] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[397/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[398/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[399/568] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[400/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[401/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[402/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[403/568] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[404/568] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[405/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[406/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[407/568] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[408/568] Linking CXX executable src/bitcoin-tx
[409/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[410/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[411/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[412/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[414/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[415/568] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[416/568] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[417/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/568] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[419/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[420/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[421/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[422/568] Linking CXX static library src/zmq/libzmq.a
[423/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[424/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[425/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[426/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[427/568] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[428/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[429/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[430/568] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[431/568] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[432/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[433/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[434/568] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[435/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[436/568] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[437/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[438/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[439/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[440/568] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[441/568] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Fabien planned changes to this revision.Jun 5 2024, 12:36

Rebase for fixing the remaining move issues

Fabien edited the summary of this revision. (Show Details)Jun 5 2024, 18:18

Fabien added a parent revision: D16288: Fix some std::move issues.

Fabien removed a parent revision: D16284: univalue: Remove unused and confusing set*() return value.

Fabien added a child revision: D16289: univalue: Avoid std::string copies.Jun 5 2024, 18:37

Harbormaster completed remote builds in B29230: Diff 48128.Jun 5 2024, 19:14

PiRK accepted this revision.Jun 6 2024, 06:40

This revision is now accepted and ready to land.Jun 6 2024, 06:40

Closed by commit rABC396e95c443fb: Fix issues when calling std::move(const&) (authored by Fabien). · Explain WhyJun 6 2024, 09:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC396e95c443fb: Fix issues when calling std::move(const&).