Page MenuHomePhabricator

Test SIGHASH_FORKID activation
ClosedPublic

Authored by deadalnix on Jun 14 2017, 19:38.

Details

Summary

This ensure that transaction that use SIGHASH_FORK are invalid before the fork and become valid after the fork.

Test Plan

Added extra checks to abc-p2p-activation.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
activateforkidsigs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 294
Build 294: arc lint + arc unit

Event Timeline

freetrader added inline comments.
qa/rpc-tests/abc-p2p-activation.py
281 ↗(On Diff #474)

add RejectResult ?

This revision now requires changes to proceed.Jun 14 2017, 22:21
qa/rpc-tests/abc-p2p-activation.py
281 ↗(On Diff #474)

There are no error code in that case.

This revision is now accepted and ready to land.Jun 14 2017, 22:34

Add error code when signature check fails.

This revision was automatically updated to reflect the committed changes.