Test SIGHASH_FORKID activation
ClosedPublic
Actions

Authored by deadalnix on Jun 14 2017, 19:38.

Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING7e10cd671caf: Test SIGHASH_FORKID activation
rABC7e10cd671caf: Test SIGHASH_FORKID activation

Summary

This ensure that transaction that use SIGHASH_FORK are invalid before the fork and become valid after the fork.

Test Plan

Added extra checks to abc-p2p-activation.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

activateforkidsigs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 294
Build 294: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 14 2017, 19:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 14 2017, 19:38

Harbormaster completed remote builds in B285: Diff 474.Jun 14 2017, 19:38

deadalnix added parent revisions: D201: Cleanup ConnectBlock, D200: Enforce that a large block is produced when the HF triggers.Jun 14 2017, 21:27

freetrader requested changes to this revision.Jun 14 2017, 22:21

freetrader added inline comments.

qa/rpc-tests/abc-p2p-activation.py
281 ↗	(On Diff #474)	add RejectResult ?

This revision now requires changes to proceed.Jun 14 2017, 22:21

deadalnix added inline comments.Jun 14 2017, 22:22

qa/rpc-tests/abc-p2p-activation.py
281 ↗	(On Diff #474)	There are no error code in that case.

freetrader accepted this revision.Jun 14 2017, 22:34

This revision is now accepted and ready to land.Jun 14 2017, 22:34

Add error code when signature check fails.

Harbormaster completed remote builds in B294: Diff 488.Jun 14 2017, 22:43

deadalnix mentioned this in T36: Ensure SIGHASH_FORKID is accepted/rejected from the mempool at apropriate time..Jun 14 2017, 22:45

Closed by commit rABC7e10cd671caf: Test SIGHASH_FORKID activation (authored by deadalnix, committed by deadalnix). · Explain WhyJun 14 2017, 22:46

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D4042: Merge #11220: Check specific validation error in miner tests.Sep 11 2019, 17:50

Revision Contents
Changeset List

Path

Size

qa/

rpc-tests/

abc-p2p-activation.py

40 lines

src/

validation.cpp

9 lines

Diff 488

View Options

qa/rpc-tests/abc-p2p-activation.py