Test HF activation accross reorg
ClosedPublic
Actions

Authored by deadalnix on Jun 16 2017, 10:26.

Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGINGebdb3ae26d32: Test HF activation accross reorg
rABCebdb3ae26d32: Test HF activation accross reorg

Summary

This tests that after reorg the replay protected transaction limited to the HF are rejected from the mempool. Right now, we just clear the mempool. This is somewhat of a blunt instrument but it will do the job.

Test Plan

make check
../qa/pull-tester/rpc-tests.py abc-p2p-activation.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 16 2017, 10:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2017, 10:26

deadalnix added a parent revision: D212: Ensure that transaction using SIGHASH_FORKID are accepted in the mempool once the HF activates.Jun 16 2017, 10:27

freetrader accepted this revision.Jun 16 2017, 10:43

freetrader added inline comments.

src/validation.cpp
2302 ↗	(On Diff #510)	black -> block
2303 ↗	(On Diff #510)	transaction -> transactions (plural)

This revision is now accepted and ready to land.Jun 16 2017, 10:43

Fix comment

Harbormaster completed remote builds in B320: Diff 523.Jun 16 2017, 12:45

Closed by commit rABCebdb3ae26d32: Test HF activation accross reorg (authored by deadalnix, committed by deadalnix). · Explain WhyJun 16 2017, 13:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

qa/

rpc-tests/

abc-p2p-activation.py

13 lines

src/

validation.cpp

40 lines

Diff 529

View Options

qa/rpc-tests/abc-p2p-activation.py