Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGaf0e7c9efefd: Require no cs_main lock for ProcessNewBlock/ActivateBestChain
rABCaf0e7c9efefd: Require no cs_main lock for ProcessNewBlock/ActivateBestChain

Summary

This requires the removal of some very liberal (incorrect) cs_mains
sprinkled in some tests. It adds some chainActive.Tip() races, but
the tests are all single-threaded anyway.

Depends on D2607, D2617 and D2631

Partial backport of core PR11824 (commit a99b76f)

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11824_part4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5088
Build 8239: Bitcoin ABC Buildbot (legacy)
Build 8238: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 26 2019, 11:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 11:01

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2609: Add an interface to get the queue depth out of CValidationInterface.Feb 26 2019, 11:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5072: Diff 7482.Feb 26 2019, 11:14

Fabien planned changes to this revision.Feb 26 2019, 17:22

jasonbcox added a subscriber: jasonbcox.Feb 26 2019, 19:28

jasonbcox added inline comments.

src/test/miner_tests.cpp
298 ↗	(On Diff #7482)	I know this has changes planned, but just pointing out that you got some tabs in here.

Fabien added inline comments.Feb 27 2019, 07:43

src/test/miner_tests.cpp
298 ↗	(On Diff #7482)	The planned changes are due to a missing dependency. These tabs are normal (intended they are spaces and not real `\t` chars), there is an added bracket pair to limit the scope of the `LOCK(cs_main)`. The closing bracket is just below.

Fabien edited the summary of this revision. (Show Details)Feb 27 2019, 08:23

Fabien added a parent revision: D2617: tests: Add missing locks to tests.

Fabien edited the summary of this revision. (Show Details)Feb 27 2019, 08:28

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Feb 27 2019, 08:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5088: Diff 7502.Feb 27 2019, 08:47

deadalnix requested changes to this revision.Feb 28 2019, 14:38

deadalnix added inline comments.

src/test/txvalidationcache_tests.cpp
67	The patch you back-port removes this.
src/wallet/test/wallet_tests.cpp
748	It seems like there is some other backport missing here, because this doesn't match what's in the backported diff.