Page MenuHomePhabricator
Differential D2784

Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
ClosedPublic
Actions

Authored by schancel on Apr 8 2019, 01:21.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
rABC0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
Summary

Remove unused parameter validFeeEstimates from CTxMempool::addUnchecked, and the
associated function for calculating this flag (IsCurrentForFeeEstimation).

The code which made use of this parameter was removed with:

Test Plan
make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
valid-fee-estimate (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5410
Build 8882: Bitcoin ABC Buildbot (legacy)
Build 8881: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 8 2019, 01:21
Owners added a reviewer: Restricted Owners Package.Apr 8 2019, 01:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2019, 01:21
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 8 2019, 01:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 8 2019, 01:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5407: Diff 7984.Apr 8 2019, 01:37
schancel updated this revision to Diff 7987.Apr 8 2019, 01:47

Fix a comment

teamcity added a comment.Apr 8 2019, 01:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 8 2019, 02:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5410: Diff 7987.Apr 8 2019, 02:02
Fabien accepted this revision.Apr 8 2019, 08:34
This revision is now accepted and ready to land.Apr 8 2019, 08:34
jasonbcox accepted this revision.Apr 8 2019, 16:25
Closed by commit rABC0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked` (authored by schancel). · Explain WhyApr 9 2019, 01:31
This revision was automatically updated to reflect the committed changes.
schancel added a commit: rSTAGING0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`.Sep 19 2019, 14:54
PiRK mentioned this in D8977: [validation] Move validation-only consts to validation.cpp.Jan 20 2021, 10:56
PiRK mentioned this in rABC6b3bb60ac35c: [validation] Move validation-only consts to validation.cpp.Jan 20 2021, 14:48

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
5 lines
8 lines
26 lines

Diff 7987

View Options

src/rpc/misc.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...