Remove much of the remaining BIP9 code
ClosedPublic
Actions

Authored by schancel on Apr 7 2019, 06:35.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code
rABC36fb94ee0821: Remove much of the remaining BIP9 code

Summary

Much of the BIP9 handling code was removed in the following revisions:

Remove BIP9 softforks test https://reviews.bitcoinabc.org/D1940
Remove bip9 from getblockchaininfo RPC call https://reviews.bitcoinabc.org/D1550
Remove bip9 version bits warning https://reviews.bitcoinabc.org/D1539
Remove the -bip9params flag https://reviews.bitcoinabc.org/D1538

This commit removes the unused versionbits handling code, and remaining extern references.

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

del-versionbits (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5419
Build 8900: Bitcoin ABC Buildbot (legacy)
Build 8899: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 7 2019, 06:35

Owners added a reviewer: Restricted Owners Package.Apr 7 2019, 06:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2019, 06:35

Herald added a reviewer: deadalnix. · View Herald Transcript

Fix missing newline

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5406: Diff 7982.Apr 7 2019, 06:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5405: Diff 7981.Apr 7 2019, 06:52

deadalnix added inline comments.Apr 8 2019, 20:00

src/validation.h
16 ↗	(On Diff #7982)	Why is that required ? Can't this be replaced favorably by a forward declaration ?

Remove chain.h as an include from validation.h

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5419: Diff 8004.Apr 9 2019, 01:38

deadalnix accepted this revision.Apr 9 2019, 14:55

This revision is now accepted and ready to land.Apr 9 2019, 14:55

Closed by commit rABC36fb94ee0821: Remove much of the remaining BIP9 code (authored by schancel). · Explain WhyApr 10 2019, 01:09

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30

schancel added a commit: rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code.Sep 19 2019, 14:55

PiRK mentioned this in D11211: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}.Mar 17 2022, 12:06

PiRK mentioned this in rABC7176fb75a43a: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}.Mar 17 2022, 14:16

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

Makefile.am

1 line

Makefile.test.include

1 line

net_processing.cpp

1 line

qt/

clientmodel.cpp

1 line

transactiondesc.cpp

1 line

transactionrecord.cpp

1 line

walletmodel.cpp

1 line

rpc/

misc.cpp

1 line

test/

CMakeLists.txt

1 line

versionbits_tests.cpp

1 line

6 lines

4 lines

66 lines

zmq/

zmqpublishnotifier.cpp

1 line

Diff 8004

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/Makefile.test.include

View Options

src/net_processing.cpp

View Options

src/qt/clientmodel.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/rpc/misc.cpp

View Options

src/test/CMakeLists.txt

View Options

src/test/versionbits_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/versionbits.h

View Options

src/versionbits.cpp

View Options

src/zmq/zmqpublishnotifier.cpp

Remove much of the remaining BIP9 codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8004

src/CMakeLists.txt

src/Makefile.am

src/Makefile.test.include

src/net_processing.cpp

src/qt/clientmodel.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/walletmodel.cpp

src/rpc/misc.cpp

src/test/CMakeLists.txt

src/test/versionbits_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

src/versionbits.h

src/versionbits.cpp

src/zmq/zmqpublishnotifier.cpp

Remove much of the remaining BIP9 code
ClosedPublic
Actions

Revision Contents
Changeset List