Page MenuHomePhabricator
Differential D2822

Remove direct bitcoin calls from qt/bantablemodel.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 23:23.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp
rABCcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/3034a462a5d30144cf0ec801d07f0c8c36d560f3
Progress towards T417
Depends on D2821

Test Plan

make check
ninja
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5536
Build 9134: Bitcoin ABC Buildbot (legacy)
Build 9133: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 23:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 23:23
teamcity added a comment.Apr 17 2019, 23:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5494: Diff 8113.Apr 17 2019, 23:37
teamcity added a comment.Apr 17 2019, 23:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien requested changes to this revision.Apr 18 2019, 08:14
Fabien added inline comments.
src/qt/bantablemodel.cpp
5 ↗(On Diff #8113)

qt/bantablemodel.h

7 ↗(On Diff #8113)

dito

8 ↗(On Diff #8113)

dito

9 ↗(On Diff #8113)

dito

This revision now requires changes to proceed.Apr 18 2019, 08:14
nakihito added a subscriber: nakihito.Apr 19 2019, 20:23

interfaces -> interfaces

jasonbcox updated this revision to Diff 8177.Apr 19 2019, 22:49

Rebase, interface -> interfaces, fixed angle brackets

teamcity added a comment.Apr 19 2019, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 23:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5536: Diff 8177.Apr 19 2019, 23:03
nakihito removed a subscriber: nakihito.Apr 19 2019, 23:03
jasonbcox added a child revision: D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.Apr 19 2019, 23:29
Fabien accepted this revision.Apr 20 2019, 13:23
This revision is now accepted and ready to land.Apr 20 2019, 13:23
Closed by commit rABCcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 23 2019, 22:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp.Sep 18 2019, 23:07

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
8 lines
qt/
9 lines
23 lines
2 lines

Diff 8177

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bantablemodel.h

Loading...
View Options

src/qt/bantablemodel.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...