Page MenuHomePhabricator
Differential D2817

Remove direct bitcoin calls from qt/splashscreen.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 17:29.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp
rABC916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/5fba3af21e44ab7552c57782de430c1f4cfd6697
Progress towards T417
Depends on D2816, D2842

Test Plan

make check
ninja
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2817
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5543
Build 9148: Bitcoin ABC Buildbot (legacy)
Build 9147: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 17:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 17:29
teamcity added a comment.Apr 17 2019, 17:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 8103.Apr 17 2019, 17:35

Fixed linker issues in the CMake build

teamcity added a comment.Apr 17 2019, 17:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 17 2019, 17:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5487: Diff 8102.Apr 17 2019, 17:43
Harbormaster completed remote builds in B5488: Diff 8103.Apr 17 2019, 17:50
teamcity added a comment.Apr 17 2019, 17:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox edited the test plan for this revision. (Show Details)Apr 17 2019, 18:17
jasonbcox added a child revision: D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.Apr 17 2019, 18:25
deadalnix requested changes to this revision.Apr 17 2019, 23:11
deadalnix added inline comments.
src/CMakeLists.txt
137 ↗(On Diff #8103)

This is incorrect.

This revision now requires changes to proceed.Apr 17 2019, 23:11
jasonbcox edited the summary of this revision. (Show Details)Apr 18 2019, 17:32
jasonbcox added a parent revision: D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.
jasonbcox updated this revision to Diff 8125.Apr 18 2019, 20:42

Fixed linking in CMake build.
interface -> interfaces
Rebase

teamcity added a comment.Apr 18 2019, 20:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 18 2019, 20:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5506: Diff 8125.Apr 18 2019, 20:58
deadalnix requested changes to this revision.Apr 19 2019, 12:51
deadalnix added inline comments.
src/CMakeLists.txt
313 ↗(On Diff #8125)

This can't possibly be correct.

This revision now requires changes to proceed.Apr 19 2019, 12:51
jasonbcox mentioned this in D2842: build: Move interfaces/* to libbitcoin_server.Apr 19 2019, 19:58
jasonbcox mentioned this in rABC176342ca4a94: build: Move interfaces/* to libbitcoin_server.Apr 19 2019, 21:33
jasonbcox updated this revision to Diff 8173.Apr 19 2019, 21:34

Rebase (with D2842, fixing the linking issue)

jasonbcox edited the summary of this revision. (Show Details)Apr 19 2019, 21:34
jasonbcox added a parent revision: D2842: build: Move interfaces/* to libbitcoin_server.
teamcity added a comment.Apr 19 2019, 21:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 21:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5532: Diff 8173.Apr 19 2019, 21:48
Fabien requested changes to this revision.Apr 20 2019, 12:51
Fabien added inline comments.
src/interfaces/wallet.h
5 ↗(On Diff #8173)

BITCOIN_INTERFACE_WALLET_H => BITCOIN_INTERFACES_WALLET_H

6 ↗(On Diff #8173)

Dito.

35 ↗(On Diff #8173)

Dito.

src/qt/splashscreen.cpp
22 ↗(On Diff #8173)

This is removed in the original PR

This revision now requires changes to proceed.Apr 20 2019, 12:51
jasonbcox updated this revision to Diff 8187.Apr 20 2019, 16:46

Fixed includes (and angle brackets) + header guards

teamcity added a comment.Apr 20 2019, 16:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 20 2019, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5543: Diff 8187.Apr 20 2019, 17:02
Fabien accepted this revision.Apr 21 2019, 19:55
jasonbcox updated this revision to Diff 8206.Apr 22 2019, 16:46

Rebase

teamcity added a comment.Apr 22 2019, 16:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5558: Diff 8206.Apr 22 2019, 17:01
teamcity added a comment.Apr 22 2019, 17:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Apr 23 2019, 20:50
This revision is now accepted and ready to land.Apr 23 2019, 20:50
Closed by commit rABC916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 23 2019, 21:19
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in rSTAGING176342ca4a94: build: Move interfaces/* to libbitcoin_server.Sep 18 2019, 23:04
jasonbcox added a commit: rSTAGING916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp.Sep 18 2019, 23:07

Revision Contents
Changeset List

PathSize
src/
3 lines
4 lines
2 lines
interfaces/
10 lines
20 lines
35 lines
33 lines
qt/
2 lines
21 lines
68 lines
wallet/
1 line

Diff 8187

View Options

src/Makefile.am

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

src/Makefile.qttest.include

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/splashscreen.h

Loading...
View Options

src/qt/splashscreen.cpp

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...