Rename variables in order to clarify what these items are associated with for a future change, which will be adding package data. Additionally, add the txSize which will be used in further diffs.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGINGcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity
rABCcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chains-for-real1 (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5772 Build 9606: Bitcoin ABC Buildbot (legacy) Build 9605: arc lint + arc unit
Event Timeline
| src/miner.h | ||
|---|---|---|
| 30 ↗ | (On Diff #8224) | Which code below? There is no code below that assumes these are negative. If you're talking about: pblocktemplate->entries.emplace_back(CTransactionRef(), -SATOSHI, 0, -1); That's because they're supposed to be out of bounds. |
| src/miner.cpp | ||
|---|---|---|
| 193 ↗ | (On Diff #8224) | @jasonbcox You can see right here that these fees are not negative. They are added to the subsidy to generate the coinbase vout. |
| 361 ↗ | (On Diff #8224) | @jasonbcox And they are added together here. So there's no funny business going on with the sign. |
| src/miner.cpp | ||
|---|---|---|
| 206 ↗ | (On Diff #8224) | Clearly txSize is being added in this diff, so it's absolutely applicable to review here. |
| src/miner.cpp | ||
|---|---|---|
| 206 ↗ | (On Diff #8224) | These original entries predate anything I've done, and the coinbase transaction is discarded in getblocktemplate with only fees being returned. The mining pool software is expected to fill in the details within the 1000 bytes of reserved space. When the generate rpc is called on regtest the IncramentExtraNonce function *does* use the coinbase, but these fields are also not used. |