Page MenuHomePhabricator
Differential D3230

Merge #10464: Introduce static DoWarning (simplify UpdateTip)
ClosedPublic
Actions

Authored by nakihito on Jun 6 2019, 00:52.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9d8d079b9f3b: Merge #10464: Introduce static DoWarning (simplify UpdateTip)
rABC9d8d079b9f3b: Merge #10464: Introduce static DoWarning (simplify UpdateTip)
Summary

f28514576 Introduce static DoWarning (simplify UpdateTip) (Jorge Timón)

Tree-SHA512: 58b39f00bc921d47d199ef1cc15e9e36f918ec86e9182de46dc2f24fa9474853a92b18d330a274a3ea7c9b001681fdfa3d86aa2bbebb5c92ac8c5a6f7690dfc1

Backport of Core PR10464
https://github.com/bitcoin/bitcoin/pull/10464/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10464
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6178
Build 10404: Bitcoin ABC Buildbot (legacy)
Build 10403: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 6 2019, 00:52
Owners added a reviewer: Restricted Owners Package.Jun 6 2019, 00:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 00:52
teamcity added a comment.Jun 6 2019, 00:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito mentioned this in D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.Jun 6 2019, 00:54
teamcity added a comment.Jun 6 2019, 01:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6178: Diff 9184.Jun 6 2019, 01:03
markblundeberg added a child revision: D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.Jun 6 2019, 04:31
markblundeberg added a comment.Jun 6 2019, 04:44

Note: other usage site was already removed in D1539.

src/validation.cpp
2160

Also backport the translation change to this warning?

markblundeberg requested changes to this revision.Jun 6 2019, 04:46
This revision now requires changes to proceed.Jun 6 2019, 04:46
nakihito updated this revision to Diff 9190.Jun 6 2019, 17:42

Rebased and added translation change to warning.

teamcity added a comment.Jun 6 2019, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jun 6 2019, 17:49
teamcity added a comment.Jun 6 2019, 17:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6183: Diff 9190.Jun 6 2019, 17:53
markblundeberg accepted this revision.Jun 6 2019, 18:52
This revision is now accepted and ready to land.Jun 6 2019, 18:52
Closed by commit rABC9d8d079b9f3b: Merge #10464: Introduce static DoWarning (simplify UpdateTip) (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJun 6 2019, 20:46
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC9d8d079b9f3b: Merge #10464: Introduce static DoWarning (simplify UpdateTip).
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING9d8d079b9f3b: Merge #10464: Introduce static DoWarning (simplify UpdateTip).Sep 19 2019, 00:05

Revision Contents
Changeset List

PathSize
src/
16 lines

Diff 9184

View Options

src/validation.cpp

Loading...