Page MenuHomePhabricator
Differential D3264

sigencoding_tests: improve test coverage
ClosedPublic
Actions

Authored by markblundeberg on Jun 8 2019, 21:43.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING9f5daed870aa: sigencoding_tests: improve test coverage
rABC9f5daed870aa: sigencoding_tests: improve test coverage
Summary

We weren't checking a huge number of hashtype byte variations for 64-byte
signatures, though some hashtype checks are done in script_tests.

This prepares for adding a Schnorr-only sigencoding checker.

Depends on D3331

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
enctests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6335
Build 10717: Bitcoin ABC Buildbot (legacy)
Build 10716: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 8 2019, 21:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2019, 21:43
teamcity added a comment.Jun 8 2019, 21:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 8 2019, 21:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6223: Diff 9261.Jun 8 2019, 21:52
markblundeberg planned changes to this revision.Jun 14 2019, 04:18
markblundeberg updated this revision to Diff 9427.Jun 14 2019, 04:35
markblundeberg edited the summary of this revision. (Show Details)
markblundeberg added a parent revision: D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

rebased onto split-up schnorr removal diffs

teamcity added a comment.Jun 14 2019, 04:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 04:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6335: Diff 9427.Jun 14 2019, 04:42
markblundeberg removed a parent revision: D3253: Remove Schnorr activation.Jun 14 2019, 04:45
markblundeberg added a child revision: D3265: add new encoding checker for Schnorr sigs.Jun 14 2019, 04:51
deadalnix accepted this revision.Jun 25 2019, 20:26
This revision is now accepted and ready to land.Jun 25 2019, 20:26
Closed by commit rABC9f5daed870aa: sigencoding_tests: improve test coverage (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 26 2019, 01:13
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC9f5daed870aa: sigencoding_tests: improve test coverage.
markblundeberg removed a child revision: D3265: add new encoding checker for Schnorr sigs.Jun 28 2019, 01:43
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING9f5daed870aa: sigencoding_tests: improve test coverage.Sep 19 2019, 00:33

Revision Contents
Changeset List

PathSize
src/
test/
43 lines

Diff 9427

View Options

src/test/sigencoding_tests.cpp

Loading...