Page MenuHomePhabricator
Differential D384

Factor out getId() from Misbehaving(..) calls
ClosedPublic
Actions

Authored by awemany on Jul 27 2017, 09:16.

Details

Reviewers
kyuupichan
freetrader
sickpig
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd60dfef8c93b: Factor out getId() from Misbehaving(..) calls
rABCd60dfef8c93b: Factor out getId() from Misbehaving(..) calls
Summary

Factor out repeated getId() calls from Misbehaving(..) lines.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D380
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 596
Build 596: arc lint + arc unit

Event Timeline

awemany created this revision.Jul 27 2017, 09:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2017, 09:16
awemany updated this revision to Diff 955.Jul 27 2017, 09:18

Add ref to D380.

Harbormaster completed remote builds in B595: Diff 955.Jul 27 2017, 09:18
deadalnix requested changes to this revision.Jul 27 2017, 10:05

What version of clang format are you using ? Maybe we should consider upgrading the one most people use because ti looks like it formats differently.

src/net_processing.cpp
808 ↗(On Diff #955)

static .

This revision now requires changes to proceed.Jul 27 2017, 10:05
awemany updated this revision to Diff 957.Jul 27 2017, 10:22
awemany edited edge metadata.

Formatting with clang-format-3.8 again.

Harbormaster completed remote builds in B596: Diff 957.Jul 27 2017, 10:22
deadalnix added inline comments.Jul 27 2017, 10:50
src/net_processing.cpp
780

Making that one static should break the build.

awemany updated this revision to Diff 958.Jul 27 2017, 10:54

Fix static

awemany marked an inline comment as done.Jul 27 2017, 10:55
awemany added inline comments.
src/net_processing.cpp
808 ↗(On Diff #955)

fixed

deadalnix accepted this revision.Jul 27 2017, 11:03
This revision is now accepted and ready to land.Jul 27 2017, 11:03
CCulianu added a subscriber: CCulianu.Jul 27 2017, 11:46

Really good you did this. I hate the way that call looked before. Good job.

Closed by commit rABCd60dfef8c93b: Factor out getId() from Misbehaving(..) calls (authored by awemany, committed by awemany). · Explain WhyJul 27 2017, 12:20
This revision was automatically updated to reflect the committed changes.
awemany marked an inline comment as done.
PiRK mentioned this in D14876: strengthen AssertLockNotHeld assertions.Nov 29 2023, 15:46
PiRK mentioned this in rABC8431faade189: strengthen AssertLockNotHeld assertions.Nov 30 2023, 10:28
PiRK mentioned this in D14903: refactor: Pass Peer& to Misbehaving().Dec 4 2023, 15:41
PiRK mentioned this in rABC070a9269782f: refactor: Pass Peer& to Misbehaving().Dec 5 2023, 07:09

Revision Contents
Changeset List

PathSize
src/
44 lines

Diff 957

View Options

src/net_processing.cpp

Loading...