Page MenuHomePhabricator
Differential D3381

Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency
ClosedPublic
Actions

Authored by markblundeberg on Jun 21 2019, 17:48.

Details

Reviewers
jasonbcox
Fabien
schancel
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0b45fa832cf3: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join…
rABC0b45fa832cf3: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join…
Summary

PR13726 backport https://github.com/bitcoin/bitcoin/pull/13726/files
5f019d5354 Removes the boost/algorithm/string/join dependency (251)

Pull request description:

This commit removes the `boost/algorithm/string/join` dependency from the project by replacing `boost::algorithm::join` with the helper function proposed by @MarcoFalke in https://github.com/bitcoin/bitcoin/pull/13726#discussion_r204159967

Backporter notes:

  • One line missing due to prior removal of versionbits logic.
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6438
Build 10923: Bitcoin ABC Buildbot (legacy)
Build 10922: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 21 2019, 17:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2019, 17:48
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 21 2019, 17:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.Jun 21 2019, 17:48

This is mostly a nominal backport -- these parts will likely be removed anyway. (see D2788)

markblundeberg planned changes to this revision.Jun 21 2019, 17:53
teamcity added a comment.Jun 21 2019, 17:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6431: Diff 9571.Jun 21 2019, 17:54
markblundeberg updated this revision to Diff 9572.Jun 21 2019, 17:56

somehow the include didn't get removed on first pass

teamcity added a comment.Jun 21 2019, 17:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 18:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6432: Diff 9572.Jun 21 2019, 18:02
jasonbcox requested changes to this revision.Jun 21 2019, 21:40
jasonbcox added inline comments.
src/validation.cpp
2111 ↗(On Diff #9572)

brackets

This revision now requires changes to proceed.Jun 21 2019, 21:40
markblundeberg added a child revision: D2788: Remove unknown version warning from UpdateTip.Jun 21 2019, 22:56
markblundeberg updated this revision to Diff 9580.Jun 21 2019, 23:00

braces

teamcity added a comment.Jun 21 2019, 23:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 23:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6438: Diff 9580.Jun 21 2019, 23:07
deadalnix accepted this revision.Jun 22 2019, 02:07
Fabien accepted this revision.Jun 24 2019, 06:18
jasonbcox accepted this revision.Jun 24 2019, 18:30
This revision is now accepted and ready to land.Jun 24 2019, 18:30
Closed by commit rABC0b45fa832cf3: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join… (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 25 2019, 02:36
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC0b45fa832cf3: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join….
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING0b45fa832cf3: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join….Sep 19 2019, 00:30

Revision Contents
Changeset List

PathSize
src/
20 lines

Diff 9580

View Options

src/validation.cpp

Loading...